docs: installation of the new iceberg_catalog_rest added to the docs
#355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
approved these changes
Apr 27, 2024
|
Also cc @Fokko and @liurenjie1024 for a review. |
| @@ -23,10 +23,11 @@ | |||
| Cargo 1.75.0 or later is required to build. | |||
| </div> | |||
|
|
|||
| Add `iceberg` into `Cargo.toml` dependencies: | |||
| Add `iceberg` and `iceberg-catalog-rest` into `Cargo.toml` dependencies: | |||
There was a problem hiding this comment.
How about splitting them into two sections as following:
Add `iceberg-catalog-rest` if you want to use rest catalog.
...
There was a problem hiding this comment.
Makes sense.
I'll push these changes in a day or two
|
cc @nishant-sachdeva Are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.