Remove unnecessary class-level synchronized in ManifestFiles #10544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was guarding `CONTENT_CACHES` access, but this field is a concurrent data structure (`Caffeine`) and does not need external synchronization.
|
@rizaon am i thinking about this right? |
Fokko
reviewed
Jun 28, 2024
Fokko
approved these changes
Jun 28, 2024
amogh-jahagirdar
approved these changes
Jul 19, 2024
|
Sorry for the late review on this @findepi , I was going through #10494 and trying to understand more about this path and saw this change as well. This particular change seems very safe to me since Caffeine already is threadsafe with respect to a given key. We don't a lock around manipulating the data structure, multiple threads can perform the dropCache and it'll be fine. |
findepi
deleted the
findepi/remove-unnecessary-class-level-synchronized-in-manifestfiles-89cf7f
branch
|
good point, @amogh-jahagirdar |
jasonf20
pushed a commit
to jasonf20/iceberg
that referenced
this pull request
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was guarding
CONTENT_CACHESaccess, but this field is a concurrent data structure (Caffeine) and does not need external synchronization.