Remove cache expiration in HiveCatalogs cache #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix looks good, is there any way to write a test though for this behavior? |
I don't think so. The check would need to be that the client pool is not closed after 10 minutes without being accessed. We expect that if a pool is closed, the tables can no longer function. And if a pool isn't closed, the tables should work fine. I don't see much to test here. |
|
Fair enough, I was just wondering |
RussellSpitzer
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the time limit that expires cache entries in
HiveCatalogs. When a catalog is evicted from the cache it is closed, which closes the client pool used by all of the tables loaded by the catalog. Any table still referenced can no longer be used, which breaks some Spark uses that keep DataFrames around.