docs:Add an example of CTAS with PARTITIONED BY (fix #3854) #4606
Conversation
|
LGTM, thanks @kyle-cx !! |
| PARTITIONED BY (part) | ||
| TBLPROPERTIES ('key'='value') | ||
| AS SELECT ... |
There was a problem hiding this comment.
I think it would make more sense to either:
- Update the existing CTAS statement above to use partitioning plus tblproperties.
- Add a comment in between the two blocks indicating what's different between the two.
I would prefer (1) given that the CTAS syntax is not iceberg specific, this is just covering more Spark DML.
…rove as suggestion from apache#4606 (comment)
docs/spark/spark-ddl.md
Outdated
| @@ -91,11 +91,15 @@ Supported transformations are: | |||
|
|
|||
| ## `CREATE TABLE ... AS SELECT` | |||
|
|
|||
| Iceberg supports CTAS as an atomic operation when using a [`SparkCatalog`](../spark-configuration#catalog-configuration). CTAS is supported, but is not atomic when using [`SparkSessionCatalog`](../spark-configuration#replacing-the-session-catalog). | |||
| Iceberg supports CTAS as an atomic operation when using a [`SparkCatalog`](../spark-configuration#catalog-configuration). CTAS is supported, but is not atomic when using [`SparkSessionCatalog`](../spark-configuration#replacing-the-session-catalog). | |||
There was a problem hiding this comment.
Can you revert the change to this line? Looks like this added trailing whitespace.
|
|
||
| ```sql | ||
| CREATE TABLE prod.db.sample | ||
| USING iceberg | ||
| PARTITIONED BY (part) | ||
| TBLPROPERTIES ('key'='value') |
There was a problem hiding this comment.
Documentation should start with simple examples and add more complexity if needed.
In this case, I think it is valid to add a PARTITIONED BY example, but not by modifying the first simple example. Please add the new paragraph and a separate example after the existing introduction to CTAS.
kyle-cx91
force-pushed
the
example_of_ctas
branch
from
623374e
to
ef03f06
Compare
… improve as suggestion from apache#4606 (comment)
kyle-cx91
force-pushed
the
example_of_ctas
branch
from
506bb57
to
ef03f06
Compare
…ove as suggestion from apache#4606 (comment)
|
@rdblue thx for the guide, and here is what it looks like now
|
| @@ -98,6 +98,15 @@ CREATE TABLE prod.db.sample | |||
| USING iceberg | |||
| AS SELECT ... | |||
| ``` | |||
| ```sql | |||
There was a problem hiding this comment.
Can you move the paragraph below up here so it's before the sql snippet? Then I think this is good to merge 👍
There was a problem hiding this comment.
@samredai sure, here is what it looks like now
…roved as suggestion from apache#4606 (comment)
|
LGTM |
|
@kyle-cx would you mind rebasing this so we can merge it in? The |
Add an example of CTAS with PARTITIONED BY, make it clear that we can use PARTITIONED BY in CTAS. @samredai
fix #3854