Verify no stream use after close in in-memory tests #5019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The in-memory `InputFile` and `OutputFile` implementations has an undesirable property that returned streams allowed use after close. Since most streams don't have such property, it should be disallowed here too.
rdblue
approved these changes
Jun 14, 2022
|
Thanks, @findepi! |
findepi
deleted the
findepi/verify-no-stream-use-after-close-in-in-memory-tests-a1d57d
branch
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
The in-memory `InputFile` and `OutputFile` implementations has an undesirable property that returned streams allowed use after close. Since most streams don't have such property, it should be disallowed here too.
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
The in-memory `InputFile` and `OutputFile` implementations has an undesirable property that returned streams allowed use after close. Since most streams don't have such property, it should be disallowed here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The in-memory
InputFileandOutputFileimplementations has anundesirable property that returned streams allowed use after close.
Since most streams don't have such property, it should be disallowed
here too.
Extracted from #4537 per #4741 (comment)