Add source snapshot info to Puffin Blob metadata #5129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
reviewed
Jun 24, 2022
core/src/main/java/org/apache/iceberg/puffin/FileMetadataParser.java
Outdated
Show resolved
Hide resolved
|
Mostly looks good. Just need to agree on and fix the names. |
findepi
force-pushed
the
findepi/add-source-snapshot-info-to-puffin-blob-metadata-d654ce
branch
from
41f824c
to
6600eda
Compare
|
AC |
rdblue
approved these changes
Jun 28, 2022
findepi
deleted the
findepi/add-source-snapshot-info-to-puffin-blob-metadata-d654ce
branch
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
|
@rdblue Now that we have this on the blob metadata level, do we still need to have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #5021