Core: Serialize statistics files in TableMetadata #5799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TableMetadataParser.toJson` now serializes table statistics. This completes the read path from JSON.
findepi
force-pushed
the
findepi/serialize-statistics-inside-table-metadata-c68a78
branch
from
0f66f3e
to
fca6101
Compare
This was referenced Sep 19, 2022
|
@rdblue this should be ready to review |
rdblue
reviewed
Sep 19, 2022
| @@ -225,6 +226,12 @@ public static void toJson(TableMetadata metadata, JsonGenerator generator) throw | |||
| } | |||
| generator.writeEndArray(); | |||
|
|
|||
| generator.writeArrayFieldStart(STATISTICS); | |||
There was a problem hiding this comment.
Can you also add deserialization? Generally when we update a parser we want to update both.
There was a problem hiding this comment.
Deserialization already exists.
Was added in #5450
The fact serialization was not covered was an omission.
nastra
approved these changes
Sep 20, 2022
rdblue
changed the title
|
Thanks, @findepi! |
findepi
deleted the
findepi/serialize-statistics-inside-table-metadata-c68a78
branch
|
thanks for the merge @rdblue ! |
sunchao
pushed a commit
to sunchao/iceberg
that referenced
this pull request
May 10, 2023
…he#894) * Core: Serialize statistics files in TableMetadata (apache#5799) (cherry picked from commit d1befd9) * Add DR support of V2 tables without delete date files Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableMetadataParser.toJsonnow serializes table statistics. Thiscompletes the read path from JSON.
Extracted from #4741 / #5794