-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Add adlfs support (Azure DataLake FileSystem) #6392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. I just have one comment about the FileNotFoundError
. I'll defer to @Fokko to also review since he catches a lot more than I do in Python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment about the credential, but apart from that this is looks great 👏🏻
8825492
to
8d998ca
Compare
@cccs-eric it looks like we have to add |
@cccs-eric I forgot one thing, could you also add the |
Yes, I'll do that. And I've also realized that I'm not calling the tests for ADLFS. Should I simply add this to python-ci.yml? - name: Tests S3
working-directory: ./python
run: make test-s3
- name: Tests Adlfs
working-directory: ./python
run: make test-adlfs |
@cccs-eric Yes, please do! |
@Fokko I don't understand what is going on. |
@cccs-eric, I just merged $6439 that fixes the pyparsing problem (my fault) so you should be able to rebase and get tests working. Sorry about that! |
edbc913
to
963bc36
Compare
Thanks @rdblue , build is now passing 🥳 |
@Fokko One last thing that I haven't done is modifying verify-release.md for the integration tests. Should I add |
@cccs-eric, looks like this was out of date. I tried to fix conflicts, but it is failing tests. Can you fix and then we'll merge? |
@rdblue All clear now |
Awesome, thanks @cccs-eric for working on this 🚀 |
Thanks, @cccs-eric! |
Adds support for adlfs storage in Python API.