IGNITE-17968 Fix write-intents being filtered out in case if it's a tombstone #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpuch
reviewed
Oct 26, 2022
There was a problem hiding this comment.
- Let's add clarifications to
#scan()javadocs: when exactly tombstones might be returned by a scan - Does
read()have same properties (like 'interpreting only not-yet-committed tombstones')? Do we have tests about this property? Ifread()behaves differently fromscan()in this regard, we probably need to note this in javadocs on both methods.
...src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvPartitionStorageTest.java
Show resolved
Hide resolved
rpuch
approved these changes
Oct 26, 2022
SammyVimes
added a commit
that referenced
this pull request
Oct 26, 2022
ivgag
pushed a commit
to unisonteam/ignite-3
that referenced
this pull request
Nov 4, 2022
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Mar 18, 2023
lowka
pushed a commit
to gridgain/apache-ignite-3
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-17968