IGNITE-19315 Validate node configuration on node start #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...nfiguration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java
Outdated
Show resolved
Hide resolved
...tegrationTest/java/org/apache/ignite/internal/configuration/ItNodeConfigurationFileTest.java
Outdated
Show resolved
Hide resolved
...tegrationTest/java/org/apache/ignite/internal/configuration/ItNodeConfigurationFileTest.java
Outdated
Show resolved
Hide resolved
...tegrationTest/java/org/apache/ignite/internal/configuration/ItNodeConfigurationFileTest.java
Outdated
Show resolved
Hide resolved
PakhomovAlexander
approved these changes
May 12, 2023
|
Looks ok to me. I would appreciate it if @ibessonov takes a look. |
tkalkirill
reviewed
May 12, 2023
...nfiguration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java
Outdated
Show resolved
Hide resolved
...uration/src/test/java/org/apache/ignite/internal/configuration/ConfigurationChangerTest.java
Show resolved
Hide resolved
...ration/src/test/java/org/apache/ignite/internal/configuration/ConfigurationRegistryTest.java
Outdated
Show resolved
Hide resolved
...ration/src/test/java/org/apache/ignite/internal/configuration/ConfigurationRegistryTest.java
Outdated
Show resolved
Hide resolved
.../runner/src/main/java/org/apache/ignite/internal/configuration/NodeConfigParseException.java
Show resolved
Hide resolved
.../runner/src/main/java/org/apache/ignite/internal/configuration/NodeConfigParseException.java
Show resolved
Hide resolved
sashapolo
reviewed
May 14, 2023
...nfiguration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java
Outdated
Show resolved
Hide resolved
...nfiguration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java
Outdated
Show resolved
Hide resolved
...ration/src/test/java/org/apache/ignite/internal/configuration/ConfigurationRegistryTest.java
Outdated
Show resolved
Hide resolved
.../runner/src/main/java/org/apache/ignite/internal/configuration/NodeConfigParseException.java
Outdated
Show resolved
Hide resolved
...tegrationTest/java/org/apache/ignite/internal/configuration/ItNodeConfigurationFileTest.java
Outdated
Show resolved
Hide resolved
...tegrationTest/java/org/apache/ignite/internal/configuration/ItNodeConfigurationFileTest.java
Outdated
Show resolved
Hide resolved
...tegrationTest/java/org/apache/ignite/internal/configuration/ItNodeConfigurationFileTest.java
Outdated
Show resolved
Hide resolved
...uration/src/test/java/org/apache/ignite/internal/configuration/ConfigurationChangerTest.java
Show resolved
Hide resolved
sashapolo
reviewed
May 16, 2023
| @@ -137,10 +139,18 @@ void missingPolymorphicExtension() { | |||
|
|
|||
| @Test | |||
| void testComplicatedPolymorphicConfig() throws Exception { | |||
|
|
|||
| Map<String, Serializable> bootstrapConfig = Map.of( | |||
There was a problem hiding this comment.
Configuration validation happens on org.apache.ignite.internal.configuration.ConfigurationChanger#start. Nulls are not allowed in the configuration, so we have to initialize null fields
...nfiguration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java
Outdated
Show resolved
Hide resolved
...nfiguration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java
Outdated
Show resolved
Hide resolved
sashapolo
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-19315