IGNITE-20000: Add planner test to verify numeric type coercion in binary arithmetic #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygerzhedovich
force-pushed
the
ignite-20000
branch
from
f67c4b5
to
17a4d3e
Compare
ygerzhedovich
force-pushed
the
ignite-20000
branch
from
17a4d3e
to
7fd03fe
Compare
zstan
reviewed
Sep 18, 2023
|
|
||
| forTypePair(NumericPair.TINYINT_DOUBLE) | ||
| .firstOpBeSame() | ||
| .secondOpMatches(castTo(Types.DECIMAL_30_15)), |
There was a problem hiding this comment.
i just still don`t understand is it correct behavior or we need additional issue, probably @lowka may help here?
Overall looks good.
There was a problem hiding this comment.
With @lowka help seems it raised from :
org.apache.calcite.sql.validate.implicit.AbstractTypeCoercion#implicitCast
// FLOAT/DOUBLE -> DECIMAL
if (SqlTypeUtil.isApproximateNumeric(in) && expected == SqlTypeFamily.EXACT_NUMERIC) {
return factory.decimalOf(in);
}
org.apache.calcite.rel.type.RelDataTypeFactoryImpl#decimalOf2 <-- here
korlov42
reviewed
Sep 18, 2023
.../test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/BaseTypeCoercionTest.java
Outdated
Show resolved
Hide resolved
...he/ignite/internal/sql/engine/planner/datatypes/NumericBinaryOperationsTypeCoercionTest.java
Show resolved
Hide resolved
zstan
approved these changes
Sep 18, 2023
|
@ygerzhedovich PR heading need to be fixed. |
zstan
changed the title
korlov42
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ary arithmetic
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes