Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-21525 Java Client: Clean up IEP-54 leftovers #3307

Merged
merged 111 commits into from
Mar 4, 2024
Merged

IGNITE-21525 Java Client: Clean up IEP-54 leftovers #3307

merged 111 commits into from
Mar 4, 2024

Conversation

ptupitsyn
Copy link
Contributor

@ptupitsyn ptupitsyn commented Feb 28, 2024 •
edited
Loading

  • Pass key column indices from SchemaDescriptor to the client
  • Refactor the logic that relies on "key columns come first" design, support any key column order
  • Fix colocation hash calculation to use keyIndex

@ptupitsyn
IGNITE-21525 Java Client: Clean up IEP-54 leftovers
72a7c50 
https://issues.apache.org/jira/browse/IGNITE-21525
@ptupitsyn
Replace keyColumnCount with keyColumns
a429058
@ptupitsyn
Replace keyColumnCount with keyColumns
d431c1e
@ptupitsyn
Fix writeTupleRaw
ae84f43
@ptupitsyn
Fix ClientTuple
9f3793b
@ptupitsyn
wip
2032d27
@ptupitsyn
wip ClientSchema
7f4b9c2
@ptupitsyn
wip ClientSchema
84573c0
@ptupitsyn
Fix toMarshallerColumns
5f632f0
@ptupitsyn
Fix toMarshallerColumns
ac5639a
@ptupitsyn
wip ClientColumn
5e82c06
@ptupitsyn
wip ClientColumn
b846984
@ptupitsyn
wip readValueTuple
0fd4e55
@ptupitsyn
wip readKvTuple
91d5b8e
@ptupitsyn
fix throwSchemaMismatchException
0986b6f
@ptupitsyn
wip ClientRecordSerializer
c130aa5
@ptupitsyn
wip ClientRecordSerializer
54c503e
@ptupitsyn
wip ClientKeyValueView
216b206
@ptupitsyn
Fix queryMapper stuff
9c381d3
@ptupitsyn
ignite-client non-test code builds
1700b50
@ptupitsyn
wip simplify ClientSchema constructor
198178f
@ptupitsyn
Simplify ClientSchema constructor
405b3d8
@ptupitsyn
Code builds, ClientTableTest passes
5698f03
@ptupitsyn
Fix runner module build
073385d
@ptupitsyn
Simplify ClientTuple, testThinClientConnectsToServerNodesAndExecutesB…
2ebc4d0 
…asicTableOperations passes
@ptupitsyn
wip MutableTupleBinaryTupleAdapter internalIndex / publicIndex
03c5410
@ptupitsyn
wip MutableTupleBinaryTupleAdapter internalIndex / publicIndex
d9b3ed7
@ptupitsyn
wip MutableTupleBinaryTupleAdapter internalIndex / publicIndex
28e807e
@ptupitsyn
wip MutableTupleBinaryTupleAdapter internalIndex / publicIndex - add …
c3b853f 
…ClientColumn.valIndex
@ptupitsyn
wip MutableTupleBinaryTupleAdapter internalIndex / publicIndex - add …
ee88441 
…ClientColumn.valIndex
@ptupitsyn ptupitsyn marked this pull request as ready for review February 29, 2024 12:23
korlov42
korlov42 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@korlov42 korlov42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good to me except for the assertion in constructor of ClientSchema. I approved this patch in advance assuming you will agree and will rework this part :) Otherwise let's sort out thing first in the corresponding thread

modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientSchema.java Outdated Show resolved Hide resolved
@ptupitsyn ptupitsyn merged commit f6ce1ac into apache:main Mar 4, 2024
1 check passed
@ptupitsyn ptupitsyn deleted the ignite-21525 branch March 4, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korlov42 korlov42 korlov42 approved these changes

@isapego isapego isapego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptupitsyn @isapego @korlov42