Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-21669 Sql. Remove sessions from SQL API #3464

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

korlov42
Copy link
Contributor

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@korlov42 korlov42 force-pushed the ignite-21669 branch 2 times, most recently from 89b340e to 4106a2c Compare March 22, 2024 10:21
@korlov42 korlov42 changed the title WIP IGNITE-21669 Sql. Remove sessions from SQL API Mar 22, 2024
@korlov42 korlov42 marked this pull request as ready for review March 22, 2024 12:38
@korlov42 korlov42 merged commit 20d296d into apache:main Mar 22, 2024
1 check passed
@korlov42 korlov42 deleted the ignite-21669 branch March 22, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants