IGNITE-22480 Sql. Avoid compiling literal-only expressions when assembling a row for insert #3922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtern
changed the title
lowka
reviewed
Jun 18, 2024
| Object val = literal.getValueAs(type); | ||
|
|
||
| // Literal was parsed as UTC timestamp, now we need to adjust it to the client's time zone. | ||
| if (val != null && literal.getTypeName() == SqlTypeName.TIMESTAMP_WITH_LOCAL_TIME_ZONE) { |
There was a problem hiding this comment.
Should we adjust TIME_WITH_LOCAL_TIME_ZONE as well?
There was a problem hiding this comment.
we have separate ticket for this https://issues.apache.org/jira/browse/IGNITE-21555
lowka
reviewed
Jun 18, 2024
| @@ -704,8 +701,36 @@ public void testRowSource() { | |||
| RexNode val10 = rexBuilder.makeExactLiteral(new BigDecimal("1"), intType); | |||
| RexNode val11 = rexBuilder.makeExactLiteral(new BigDecimal("2"), bigIntType); | |||
There was a problem hiding this comment.
- I think we need to ensure that DECIMAL values preserve precision/scale after this transformation.
- Ideally, we need to check literals of all types here.
There was a problem hiding this comment.
Thanks, the test has been improved, please take a look again.
korlov42
approved these changes
Jun 19, 2024
lowka
approved these changes
Jun 19, 2024
AMashenkov
reviewed
Jun 20, 2024
| // Avoiding compilation when all expressions are constants. | ||
| for (int i = 0; i < values.size(); i++) { | ||
| if (!(values.get(i) instanceof RexLiteral)) { | ||
| return new ValuesImpl(scalar(values, null), ctx.rowHandler().factory(rowSchema)); |
There was a problem hiding this comment.
Factory could be cached in local variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-22480