IGNITE-16266 Add unique id for indexes #672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMashenkov
force-pushed
the
ignite-16266
branch
from
d3c0e98
to
c08a2e7
Compare
korlov42
force-pushed
the
ignite-14925-sorted-indexes
branch
from
9f9202d
to
870fa15
Compare
korlov42
force-pushed
the
ignite-16266
branch
from
c08a2e7
to
4a4e4e7
Compare
korlov42
requested changes
Feb 25, 2022
There was a problem hiding this comment.
Hi, @AMashenkov! What about SQL-related part? We need to fix that as well. You could use patch from this ticket as reference.
korlov42
reviewed
Mar 30, 2022
...es/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/AbstractIndexScan.java
Outdated
Show resolved
Hide resolved
...ql-engine/src/main/java/org/apache/ignite/internal/sql/engine/externalize/RelJsonReader.java
Outdated
Show resolved
Hide resolved
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/IgniteIndex.java
Outdated
Show resolved
Hide resolved
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/IgniteIndex.java
Outdated
Show resolved
Hide resolved
| * @param idxName Index name. | ||
| * @throws IndexNotFoundException If not found. | ||
| */ | ||
| void checkIndexById(String tag, String idxName); |
There was a problem hiding this comment.
why do we need a idxName param here?
There was a problem hiding this comment.
I fix RelInputImpl#checkIndexById method, my fail, name needed only for possible error message.
modules/index-api/src/main/java/org/apache/ignite/internal/idx/IndexManager.java
Outdated
Show resolved
Hide resolved
korlov42
reviewed
Apr 1, 2022
...s/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/externalize/RelInputEx.java
Outdated
Show resolved
Hide resolved
...s/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/externalize/RelInputEx.java
Show resolved
Hide resolved
...es/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/AbstractIndexScan.java
Show resolved
Hide resolved
| InternalSortedIndex idx = indexManager.getIndexById(id); | ||
|
|
||
| if (idx == null) { | ||
| throw new IndexNotFoundException(idxName, id); |
There was a problem hiding this comment.
This doesn't seem right to pass an idxName param only for case when index is not found. Probably, there should be one more constructor of IndexNotFoundException accepting the Id only
...ngine/src/test/java/org/apache/ignite/internal/sql/engine/externalize/RelJsonReaderTest.java
Outdated
Show resolved
Hide resolved
korlov42
reviewed
Apr 4, 2022
.../sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManager.java
Outdated
Show resolved
Hide resolved
...-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManagerImpl.java
Outdated
Show resolved
Hide resolved
...ngine/src/test/java/org/apache/ignite/internal/sql/engine/externalize/RelJsonReaderTest.java
Outdated
Show resolved
Hide resolved
...ngine/src/test/java/org/apache/ignite/internal/sql/engine/externalize/RelJsonReaderTest.java
Outdated
Show resolved
Hide resolved
...ngine/src/test/java/org/apache/ignite/internal/sql/engine/externalize/RelJsonReaderTest.java
Outdated
Show resolved
Hide resolved
...s/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/externalize/RelInputEx.java
Show resolved
Hide resolved
korlov42
approved these changes
Apr 6, 2022
AMashenkov
commented
Apr 6, 2022
| IgniteIndex old = indexById.remove(idx0.id()); | ||
|
|
||
| if (old == null) { | ||
| LOG.trace(IgniteStringFormatter.format("Index [name={}] not found in inner store.", idxName)); |
There was a problem hiding this comment.
Let's avoid string creation if the TRACE log-level is disabled.
Suggested change
| LOG.trace(IgniteStringFormatter.format("Index [name={}] not found in inner store.", idxName)); | |
| LOG.trace(() -> IgniteStringFormatter.format("Index [name={}] not found in inner store.", idxName)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-16266