Skip to content

Commit c9bbb2f

Browse files
authored
IGNITE-26259 Use MessageSerializer for GridQueryCancelRequest (#12291)
1 parent c66c653 commit c9bbb2f

File tree

2 files changed

+11
-45
lines changed

2 files changed

+11
-45
lines changed

modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
import org.apache.ignite.internal.codegen.GridIntListSerializer;
3939
import org.apache.ignite.internal.codegen.GridJobCancelRequestSerializer;
4040
import org.apache.ignite.internal.codegen.GridJobSiblingsRequestSerializer;
41+
import org.apache.ignite.internal.codegen.GridQueryCancelRequestSerializer;
4142
import org.apache.ignite.internal.codegen.GridQueryFailResponseSerializer;
4243
import org.apache.ignite.internal.codegen.GridQueryKillRequestSerializer;
4344
import org.apache.ignite.internal.codegen.GridQueryKillResponseSerializer;
@@ -316,7 +317,7 @@ public class GridIoMessageFactory implements MessageFactoryProvider {
316317
factory.register((short)102, CacheVersionedValue::new, new CacheVersionedValueSerializer());
317318
factory.register((short)103, GridCacheRawVersionedEntry::new);
318319
factory.register((short)104, GridCacheVersionEx::new, new GridCacheVersionExSerializer());
319-
factory.register((short)106, GridQueryCancelRequest::new);
320+
factory.register((short)106, GridQueryCancelRequest::new, new GridQueryCancelRequestSerializer());
320321
factory.register((short)107, GridQueryFailResponse::new, new GridQueryFailResponseSerializer());
321322
factory.register((short)108, GridQueryNextPageRequest::new, new GridQueryNextPageRequestSerializer());
322323
factory.register((short)109, GridQueryNextPageResponse::new, new GridQueryNextPageResponseSerializer());

modules/core/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/messages/GridQueryCancelRequest.java

Lines changed: 9 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,16 @@
1717

1818
package org.apache.ignite.internal.processors.query.h2.twostep.messages;
1919

20-
import java.nio.ByteBuffer;
20+
import org.apache.ignite.internal.Order;
2121
import org.apache.ignite.internal.util.typedef.internal.S;
2222
import org.apache.ignite.plugin.extensions.communication.Message;
23-
import org.apache.ignite.plugin.extensions.communication.MessageReader;
24-
import org.apache.ignite.plugin.extensions.communication.MessageWriter;
2523

2624
/**
2725
* Cancel map part of query request.
2826
*/
2927
public class GridQueryCancelRequest implements Message {
3028
/** */
29+
@Order(value = 0, method = "queryRequestId")
3130
private long qryReqId;
3231

3332
/**
@@ -51,50 +50,16 @@ public long queryRequestId() {
5150
return qryReqId;
5251
}
5352

54-
/** {@inheritDoc} */
55-
@Override public String toString() {
56-
return S.toString(GridQueryCancelRequest.class, this);
57-
}
58-
59-
/** {@inheritDoc} */
60-
@Override public boolean writeTo(ByteBuffer buf, MessageWriter writer) {
61-
writer.setBuffer(buf);
62-
63-
if (!writer.isHeaderWritten()) {
64-
if (!writer.writeHeader(directType()))
65-
return false;
66-
67-
writer.onHeaderWritten();
68-
}
69-
70-
switch (writer.state()) {
71-
case 0:
72-
if (!writer.writeLong(qryReqId))
73-
return false;
74-
75-
writer.incrementState();
76-
77-
}
78-
79-
return true;
53+
/**
54+
* @param qryReqId Query request ID.
55+
*/
56+
public void queryRequestId(long qryReqId) {
57+
this.qryReqId = qryReqId;
8058
}
8159

8260
/** {@inheritDoc} */
83-
@Override public boolean readFrom(ByteBuffer buf, MessageReader reader) {
84-
reader.setBuffer(buf);
85-
86-
switch (reader.state()) {
87-
case 0:
88-
qryReqId = reader.readLong();
89-
90-
if (!reader.isLastRead())
91-
return false;
92-
93-
reader.incrementState();
94-
95-
}
96-
97-
return true;
61+
@Override public String toString() {
62+
return S.toString(GridQueryCancelRequest.class, this);
9863
}
9964

10065
/** {@inheritDoc} */

0 commit comments

Comments
 (0)