IGNITE-15062 Events for snapshot restore operation. #9240
Conversation
| @@ -86,6 +87,12 @@ | |||
| /** Reject operation message. */ | |||
| private static final String OP_REJECT_MSG = "Cache group restore operation was rejected. "; | |||
|
|
|||
| /** Snapshot restore operation finish message. */ | |||
| private static final String OP_FINISHED_MSG = "Successfully restored cache group(s) from the snapshot [reqId=%s]"; | |||
There was a problem hiding this comment.
Let's use the right word order Subject + Verb + Object: Cache groups have been successfully restored from snapshot.
Do we need a request Id? I'd rather use the cache group names or remove it at all.
There was a problem hiding this comment.
These constants were introduced in order to use the same message in logs and events.
This is how the logging looks now, I don't think there is a problem with changing this wording in the log.
But I think we must specify the request ID so that we can find the rest of the events/log-messages/etc related to this one.
| private static final String OP_FINISHED_MSG = "Successfully restored cache group(s) from the snapshot [reqId=%s]"; | ||
|
|
||
| /** Snapshot restore operation failed message. */ | ||
| private static final String OP_FAILED_MSG = "Failed to restore snapshot cache group [reqId=%s%s]"; |
There was a problem hiding this comment.
reqId=%s%s why do we mix a request id and message here?
There was a problem hiding this comment.
What kind of problem do you see here?
This is the general message format for the event and a log message. Additional %s adds the error message to the event message (but does not include it in the log message, since we handle errors in the log in a different way).
)" This reverts commit 5d8d637
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.