Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apache-annotator meta-package #94

Merged
merged 2 commits into from
Sep 20, 2020
Merged

Add apache-annotator meta-package #94

merged 2 commits into from
Sep 20, 2020

Conversation

Treora
Copy link
Contributor

@Treora Treora commented Sep 18, 2020

A step towards addressing issue #90. This first approach exports through both ways I mentioned there, so a user can do either of the following:

import { … } from 'apache-annotator/dom';

import { dom } from 'apache-annotator';

I’d be happy to drop one of the two if there is no reason to keep both.

Before a release, we’d have to manually update the packages’ version numbers in package.json. Also when adding a package, we’d have to add it manually in several places. Neither is too much hassle I suppose, but if there’s a simple way to automate such tasks that could be nice.

@tilgovi
Copy link
Contributor

tilgovi commented Sep 18, 2020

Before a release, we’d have to manually update the packages’ version numbers in package.json. Also when adding a package, we’d have to add it manually in several places. Neither is too much hassle I suppose, but if there’s a simple way to automate such tasks that could be nice.

I think this can be automated with lerna or yarn.

{
"name": "apache-annotator",
"version": "0.1.0",
"description": "Web Annotation selector for engine.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe pull the description from the root package.json. The root one might not even need a description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes; I just copied the package.json from the selector package. We should probably give that one a less cryptic description some day. :)
I see that while copying I also left its dependencies, and pointer to its type declaration file; I removed both.

Copy link
Contributor

@tilgovi tilgovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I left two small comments, but this is perfect.

@tilgovi
Copy link
Contributor

tilgovi commented Sep 20, 2020

I believe we do want the types and the dependencies. Even just importing things leads to the build having babel import helpers from the runtime package. We may not need core-js@3 at all, since I think it's bundled in the babel runtime package. I'll remove that after I merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants