Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize templates, script, and plugin nil pointer checks #1073

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

sosyz
Copy link
Member

@sosyz sosyz commented Aug 15, 2024

This pull request includes three commits that improve performance and update scripts.

The first commit removes an invalid nil pointer check in the Translate function.

The second commit updates the check-asf-header.sh script to support Podman, in addition to Docker. This ensures compatibility with both container runtimes.

The third commit removes extra characters in the header.html file, addressing issue #1066.

@LinkinStars
Copy link
Member

LGTM

@LinkinStars LinkinStars self-assigned this Aug 16, 2024
@LinkinStars LinkinStars self-requested a review August 16, 2024 03:16
@LinkinStars LinkinStars merged commit d63ce36 into apache:dev Aug 16, 2024
@sosyz sosyz deleted the Sonui/perf_08_07_2024 branch September 16, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants