Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: gitlab adopts new remote api helper #6546

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

klesh
Copy link
Contributor

@klesh klesh commented Dec 1, 2023

Summary

refactor: Gitlab adopts new remote API helper

Feature #5914 has been reverted:

  • The list remote scopes API won't include projects under other user's account
  • You may still add them by using the search remote scope
    Because:
  • No Gitlab API can be utilized elegantly for the purpose, the current implementation uses the /projects API which also returns many other unneeded entries that need to be dropped which is inefficiency and may cause significant delay on the config-ui when the total number of projects is huge.
  • The implementation is too complicated to understand
  • The deduplication from the current implementation was flawed
  • The use-case of "adding projects under another user's name" is rare, it is not worth the trouble. Search and add is good enough

Does this close any open issues?

Part of #5519

Screenshots

gitlab-list-repo gitlab-list-subgroups gitlab-proxy gitlab-search-repos

@klesh klesh added this to the v0.21 milestone Dec 1, 2023
@d4x1 d4x1 merged commit 38abeb5 into main Dec 1, 2023
11 checks passed
@d4x1 d4x1 deleted the kw-5519-dshelper branch December 1, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants