Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: startedDate and finishedDate should be required #7553

Merged
merged 1 commit into from
May 31, 2024
Merged

fix: startedDate and finishedDate should be required #7553

merged 1 commit into from
May 31, 2024

Conversation

klesh
Copy link
Contributor

@klesh klesh commented May 31, 2024

Summary

fix: startedDate and finishedDate should be required according to @louis

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. component/plugins This issue or PR relates to plugins severity/p1 This bug affects functionality or significantly affect ux type/bug This issue is a bug labels May 31, 2024
Startrekzky
Startrekzky approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@Startrekzky Startrekzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 31, 2024
@Startrekzky Startrekzky merged commit afd1763 into main May 31, 2024
15 checks passed
@Startrekzky Startrekzky deleted the kw-webhook-deployment-required branch May 31, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Startrekzky Startrekzky Startrekzky approved these changes

Assignees
No one assigned
Labels
component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer severity/p1 This bug affects functionality or significantly affect ux size:XS This PR changes 0-9 lines, ignoring generated files. type/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klesh @Startrekzky