Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webhook): rollback database when webhook's name is same #7778

Merged
merged 2 commits into from
Jul 24, 2024
Merged

fix(webhook): rollback database when webhook's name is same #7778

merged 2 commits into from
Jul 24, 2024

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Jul 24, 2024 •
edited
Loading

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
Rollback database transaction when webhook's name is same.

Does this close any open issues?

Closes N/A.

Screenshots

Include any relevant screenshots here.
image

Other Information

Any other information that is important to this PR.

@d4x1 d4x1 requested a review from abeizn July 24, 2024 08:15
@d4x1 d4x1 self-assigned this Jul 24, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. component/plugins This issue or PR relates to plugins type/bug This issue is a bug labels Jul 24, 2024
abeizn
abeizn previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@abeizn abeizn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 24, 2024
@abeizn abeizn merged commit d975148 into main Jul 24, 2024
10 checks passed
@abeizn abeizn deleted the dev-1 branch July 24, 2024 08:24
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@d4x1
fix(webhook): rollback database when webhook's name is same (#7778)
6849ca0 
* fix(webhook): rollback database when webhook's name is same

* fix(webhook): update error messages
@github-actions github-actions bot mentioned this pull request Jul 24, 2024
Merged
@github-actions GitHub Actions
Copy link

🤖 Target: #release-v0.21 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Jul 24, 2024
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@d4x1
fix(webhook): rollback database when webhook's name is same (#7778)
96157f9 
* fix(webhook): rollback database when webhook's name is same

* fix(webhook): update error messages
@github-actions github-actions bot mentioned this pull request Jul 24, 2024
Merged
@github-actions GitHub Actions
Copy link

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

abeizn pushed a commit that referenced this pull request Jul 24, 2024
@github-actions @d4x1
fix(webhook): rollback database when webhook's name is same (#7778) (#…
6137e4a 
…7779)

* fix(webhook): rollback database when webhook's name is same

* fix(webhook): update error messages

Co-authored-by: Lynwee <1507509064@qq.com>
abeizn pushed a commit that referenced this pull request Jul 24, 2024
@github-actions @d4x1
fix(webhook): rollback database when webhook's name is same (#7778) (#…
914d924 
…7780)

* fix(webhook): rollback database when webhook's name is same

* fix(webhook): update error messages

Co-authored-by: Lynwee <1507509064@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeizn abeizn abeizn approved these changes

Assignees

@d4x1 d4x1

Labels
bot/auto-cherry-pick-completed auto cherry pick completed component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer needs-cherrypick-v0.21 needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug size:XS This PR changes 0-9 lines, ignoring generated files. type/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d4x1 @abeizn