Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-2629][VL] Use Project + Unnest to implement Expand operator #2630

Closed
wants to merge 1 commit into from

Conversation

JkSelf
Copy link
Contributor

@JkSelf JkSelf commented Aug 7, 2023

What changes were proposed in this pull request?

As discussed in facebookincubator/velox#5958, we can implement the Expand operator by Project + Unnest. And no need adding new Expand operator in Velox.

How was this patch tested?

Existing unit tests

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

#2629

@JkSelf
Copy link
Contributor Author

JkSelf commented Aug 8, 2023

@zhli1142015 Can you help to review? Thanks.

Copy link
Contributor

@winningsix winningsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any UT to validate ExpandRel to unnest -> project?

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Nov 17, 2023
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants