Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[VL] Make bloom_filter_agg fall back when might_contain is not transformable (#3917)" #3977

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

loneylee
Copy link
Member

@loneylee loneylee commented Dec 8, 2023

What changes were proposed in this pull request?

In clickhouse backend,pr #3917 cause an inconsistent results.

Loop execution tpch100 1~22 queries, q20 will return empty result instead of 17971 rows correct answer.

ITRJA6kqCF

@loneylee loneylee marked this pull request as ready for review December 8, 2023 03:15
Copy link

github-actions bot commented Dec 8, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,let‘s merge

@baibaichen baibaichen merged commit e9ea4e3 into apache:main Dec 8, 2023
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3977_time.csv log/native_master_12_07_2023_9c5314fd5_time.csv difference percentage
q1 35.46 33.97 -1.492 95.79%
q2 24.62 24.95 0.327 101.33%
q3 38.66 37.91 -0.753 98.05%
q4 37.99 37.39 -0.598 98.43%
q5 72.27 71.30 -0.970 98.66%
q6 6.92 5.38 -1.544 77.70%
q7 84.14 85.81 1.667 101.98%
q8 86.80 85.80 -1.002 98.85%
q9 125.98 123.51 -2.475 98.04%
q10 44.07 45.87 1.800 104.08%
q11 21.27 20.29 -0.984 95.37%
q12 25.43 26.73 1.298 105.10%
q13 45.74 45.73 -0.003 99.99%
q14 15.95 16.69 0.748 104.69%
q15 29.16 28.46 -0.700 97.60%
q16 15.64 15.56 -0.085 99.45%
q17 101.16 103.37 2.206 102.18%
q18 151.64 149.01 -2.623 98.27%
q19 13.01 12.84 -0.168 98.71%
q20 27.56 27.78 0.221 100.80%
q21 224.48 223.73 -0.751 99.67%
q22 13.03 13.39 0.359 102.75%
total 1240.99 1235.47 -5.521 99.56%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_12_09_2023_time.csv log/native_master_12_07_2023_9c5314fd5_time.csv difference percentage
q1 34.55 33.97 -0.581 98.32%
q2 24.93 24.95 0.012 100.05%
q3 39.07 37.91 -1.163 97.02%
q4 37.36 37.39 0.036 100.10%
q5 72.10 71.30 -0.800 98.89%
q6 7.04 5.38 -1.662 76.40%
q7 86.60 85.81 -0.784 99.09%
q8 86.98 85.80 -1.178 98.65%
q9 127.70 123.51 -4.189 96.72%
q10 43.95 45.87 1.922 104.37%
q11 20.59 20.29 -0.299 98.55%
q12 24.71 26.73 2.018 108.17%
q13 46.16 45.73 -0.427 99.07%
q14 15.98 16.69 0.714 104.47%
q15 28.08 28.46 0.380 101.35%
q16 15.48 15.56 0.075 100.48%
q17 101.87 103.37 1.504 101.48%
q18 151.21 149.01 -2.202 98.54%
q19 12.86 12.84 -0.021 99.83%
q20 28.47 27.78 -0.692 97.57%
q21 223.57 223.73 0.163 100.07%
q22 13.25 13.39 0.139 101.05%
total 1242.51 1235.47 -7.038 99.43%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_12_09_2023_time.csv log/native_master_12_09_2023_e9ea4e3e4_time.csv difference percentage
q1 33.79 34.55 0.754 102.23%
q2 26.29 24.93 -1.354 94.85%
q3 37.96 39.07 1.109 102.92%
q4 37.26 37.36 0.101 100.27%
q5 71.58 72.10 0.529 100.74%
q6 6.95 7.04 0.091 101.31%
q7 85.58 86.60 1.017 101.19%
q8 86.99 86.98 -0.018 99.98%
q9 122.66 127.70 5.036 104.11%
q10 44.48 43.95 -0.533 98.80%
q11 20.31 20.59 0.278 101.37%
q12 25.94 24.71 -1.230 95.26%
q13 46.85 46.16 -0.693 98.52%
q14 18.60 15.98 -2.617 85.93%
q15 27.72 28.08 0.357 101.29%
q16 15.79 15.48 -0.305 98.07%
q17 103.32 101.87 -1.450 98.60%
q18 150.86 151.21 0.357 100.24%
q19 13.88 12.86 -1.013 92.70%
q20 27.54 28.47 0.929 103.37%
q21 225.34 223.57 -1.773 99.21%
q22 13.18 13.25 0.071 100.54%
total 1242.86 1242.51 -0.358 99.97%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_12_10_2023_time.csv log/native_master_12_09_2023_e9ea4e3e4_time.csv difference percentage
q1 34.68 33.79 -0.885 97.45%
q2 27.19 26.29 -0.907 96.67%
q3 37.58 37.96 0.386 101.03%
q4 37.98 37.26 -0.725 98.09%
q5 70.50 71.58 1.078 101.53%
q6 6.93 6.95 0.024 100.35%
q7 84.23 85.58 1.350 101.60%
q8 85.45 86.99 1.540 101.80%
q9 126.22 122.66 -3.560 97.18%
q10 43.28 44.48 1.203 102.78%
q11 19.94 20.31 0.375 101.88%
q12 27.48 25.94 -1.538 94.40%
q13 47.58 46.85 -0.728 98.47%
q14 16.51 18.60 2.087 112.64%
q15 27.43 27.72 0.296 101.08%
q16 15.68 15.79 0.105 100.67%
q17 104.55 103.32 -1.238 98.82%
q18 149.27 150.86 1.591 101.07%
q19 13.60 13.88 0.280 102.06%
q20 27.18 27.54 0.358 101.32%
q21 225.87 225.34 -0.529 99.77%
q22 13.10 13.18 0.082 100.62%
total 1242.22 1242.86 0.647 100.05%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants