Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Support DecimalType for approx_count_distinct #5868

Merged
merged 1 commit into from
May 27, 2024

Conversation

liujiayi771
Copy link
Contributor

@liujiayi771 liujiayi771 commented May 25, 2024

What changes were proposed in this pull request?

Velox's approx_distinct supports decimal type, we can add the support for decimal type in the HLLRewriteRule.

How was this patch tested?

Add a new test case for approx_count_distinct decimal type.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@liujiayi771
Copy link
Contributor Author

cc @zhli1142015 @zhztheplayer, thanks.

@zhli1142015 zhli1142015 merged commit efd6f31 into apache:main May 27, 2024
39 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5868_time.csv log/native_master_05_27_2024_56c5a24c1_time.csv difference percentage
q1 34.00 33.83 -0.170 99.50%
q2 25.76 23.77 -1.993 92.26%
q3 36.46 36.69 0.225 100.62%
q4 35.83 35.09 -0.731 97.96%
q5 67.27 68.27 0.996 101.48%
q6 7.38 5.98 -1.403 81.00%
q7 79.49 78.74 -0.748 99.06%
q8 82.69 83.78 1.089 101.32%
q9 122.20 119.36 -2.844 97.67%
q10 45.18 45.89 0.704 101.56%
q11 20.34 19.70 -0.641 96.85%
q12 26.21 27.26 1.047 104.00%
q13 52.02 52.73 0.708 101.36%
q14 19.98 17.65 -2.330 88.34%
q15 30.27 31.35 1.085 103.59%
q16 13.82 14.31 0.491 103.55%
q17 103.96 102.68 -1.275 98.77%
q18 146.14 145.45 -0.695 99.52%
q19 13.77 15.24 1.472 110.69%
q20 28.32 27.93 -0.392 98.62%
q21 264.85 261.25 -3.600 98.64%
q22 12.66 13.57 0.911 107.20%
total 1268.60 1260.51 -8.092 99.36%

@liujiayi771 liujiayi771 deleted the approx_count_distinct_decimal branch May 27, 2024 13:58
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_05_27_2024_time.csv log/native_master_05_17_2024_63c166d62_time.csv difference percentage
q1 15.37 15.13 -0.239 98.45%
q2 15.78 16.79 1.008 106.39%
q3 4.39 4.54 0.148 103.37%
q4 64.02 63.43 -0.591 99.08%
q5 8.19 7.98 -0.201 97.55%
q6 2.67 2.68 0.010 100.38%
q7 6.21 5.77 -0.437 92.96%
q8 3.35 3.20 -0.156 95.34%
q9 18.08 17.36 -0.720 96.02%
q10 10.51 9.21 -1.297 87.66%
q11 35.26 39.71 4.450 112.62%
q12 1.51 1.38 -0.124 91.78%
q13 5.60 7.20 1.601 128.60%
q14a 44.21 45.35 1.139 102.58%
q14b 41.63 42.63 1.000 102.40%
q15 3.81 2.66 -1.144 69.96%
q16 39.72 39.63 -0.084 99.79%
q17 5.72 5.72 0.005 100.08%
q18 9.08 5.89 -3.185 64.91%
q19 3.49 2.08 -1.407 59.69%
q20 1.45 1.27 -0.176 87.82%
q21 1.20 3.38 2.180 281.88%
q22 7.98 8.07 0.095 101.19%
q23a 81.64 81.82 0.175 100.21%
q23b 99.94 102.03 2.091 102.09%
q24a 72.11 81.04 8.939 112.40%
q24b 79.45 69.18 -10.268 87.08%
q25 4.56 4.29 -0.266 94.17%
q26 10.31 4.31 -6.001 41.80%
q27 2.66 2.94 0.282 110.59%
q28 22.02 21.47 -0.549 97.51%
q29 7.00 9.56 2.555 136.50%
q30 4.12 4.11 -0.009 99.78%
q31 5.95 6.03 0.076 101.27%
q32 1.24 1.18 -0.058 95.33%
q33 4.75 6.85 2.100 144.23%
q34 4.66 4.94 0.278 105.97%
q35 7.93 7.00 -0.927 88.30%
q36 3.18 3.23 0.047 101.48%
q37 3.93 4.22 0.286 107.27%
q38 11.84 11.80 -0.043 99.64%
q39a 3.35 3.34 -0.005 99.84%
q39b 2.79 2.81 0.017 100.60%
q40 3.83 5.45 1.618 142.23%
q41 0.56 0.53 -0.029 94.75%
q42 0.94 0.92 -0.020 97.87%
q43 3.55 3.48 -0.069 98.06%
q44 7.08 7.20 0.116 101.64%
q45 3.51 3.86 0.357 110.19%
q46 3.03 2.92 -0.108 96.42%
q47 14.84 15.92 1.079 107.27%
q48 4.40 4.39 -0.011 99.75%
q49 7.41 6.97 -0.439 94.07%
q50 24.44 29.36 4.919 120.12%
q51 8.72 8.59 -0.140 98.40%
q52 0.99 1.06 0.073 107.40%
q53 1.79 1.68 -0.105 94.12%
q54 3.30 3.12 -0.177 94.64%
q55 0.94 1.14 0.201 121.25%
q56 4.38 5.39 1.005 122.93%
q57 8.52 8.39 -0.127 98.51%
q58 2.71 2.50 -0.214 92.10%
q59 16.41 16.51 0.105 100.64%
q60 5.10 5.84 0.734 114.38%
q61 5.28 6.35 1.073 120.33%
q62 4.25 10.04 5.789 236.09%
q63 1.85 1.84 -0.019 98.95%
q64 49.92 49.22 -0.694 98.61%
q65 13.56 13.50 -0.065 99.52%
q66 3.01 3.04 0.024 100.81%
q67 354.16 352.18 -1.986 99.44%
q68 3.50 3.70 0.199 105.70%
q69 6.78 8.44 1.660 124.49%
q70 8.76 8.36 -0.390 95.54%
q71 2.27 2.13 -0.133 94.12%
q72 191.86 188.15 -3.713 98.06%
q73 2.29 2.12 -0.171 92.52%
q74 21.60 21.15 -0.442 97.95%
q75 23.74 24.96 1.219 105.13%
q76 7.03 10.01 2.979 142.36%
q77 1.78 1.74 -0.045 97.47%
q78 39.90 38.43 -1.462 96.34%
q79 3.47 3.32 -0.155 95.52%
q80 10.58 11.12 0.538 105.08%
q81 4.53 6.56 2.022 144.59%
q82 8.65 6.26 -2.389 72.37%
q83 1.46 1.38 -0.079 94.54%
q84 2.93 2.85 -0.080 97.26%
q85 7.13 7.05 -0.080 98.88%
q86 3.19 3.22 0.023 100.72%
q87 12.28 12.21 -0.069 99.44%
q88 16.77 18.97 2.194 113.08%
q89 2.65 2.62 -0.030 98.86%
q90 3.40 6.16 2.761 181.14%
q91 2.57 2.86 0.285 111.07%
q92 1.14 1.26 0.119 110.40%
q93 31.14 28.95 -2.193 92.96%
q94 21.35 21.37 0.023 100.11%
q9 81.54 86.82 5.272 106.47%
q5 6.35 2.21 -4.139 34.79%
q96 11.98 12.19 0.205 101.71%
q97 1.82 2.02 0.194 110.63%
q98 9.80 9.26 -0.546 94.43%
q99 9.80 9.26 -0.546 94.43%
total 1895.41 1912.46 17.055 100.90%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_05_27_2024_time.csv log/native_master_05_27_2024_56c5a24c1_time.csv difference percentage
q1 34.01 33.83 -0.187 99.45%
q2 25.69 23.77 -1.929 92.49%
q3 36.59 36.69 0.096 100.26%
q4 34.28 35.09 0.811 102.36%
q5 70.33 68.27 -2.060 97.07%
q6 7.60 5.98 -1.621 78.67%
q7 82.15 78.74 -3.409 95.85%
q8 88.29 83.78 -4.504 94.90%
q9 122.17 119.36 -2.816 97.70%
q10 46.70 45.89 -0.813 98.26%
q11 20.07 19.70 -0.374 98.14%
q12 23.62 27.26 3.640 115.41%
q13 53.35 52.73 -0.623 98.83%
q14 17.13 17.65 0.518 103.02%
q15 31.65 31.35 -0.296 99.06%
q16 13.86 14.31 0.446 103.22%
q17 103.47 102.68 -0.786 99.24%
q18 144.12 145.45 1.331 100.92%
q19 13.72 15.24 1.527 111.13%
q20 28.10 27.93 -0.167 99.40%
q21 260.32 261.25 0.927 100.36%
q22 12.53 13.57 1.041 108.31%
total 1269.76 1260.51 -9.248 99.27%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants