-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Support DecimalType for approx_count_distinct #5868
[VL] Support DecimalType for approx_count_distinct #5868
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
a64a7a2
to
f99168c
Compare
cc @zhli1142015 @zhztheplayer, thanks. |
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Velox's
approx_distinct
supports decimal type, we can add the support for decimal type in theHLLRewriteRule
.How was this patch tested?
Add a new test case for approx_count_distinct decimal type.