Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6064][VL] Support loading shared libraries on RedHat-9 #6063

Merged
merged 6 commits into from
Jun 19, 2024

Conversation

deepashreeraghu
Copy link
Contributor

What changes were proposed in this pull request?

Trying to use the centos-8 based Gluten jar on RHEL9.

How was this patch tested?

I have used the centos-8 based Gluten jar on RHEL9 and this is the first step it fails. Once I added this fix, it proceeds well.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@deepashreeraghu
Copy link
Contributor Author

Created issue for the same - #6064

@zhztheplayer zhztheplayer changed the title [Gluten] Support libraryloader on RedHat-9 [VL] Support libraryloader on RedHat-9 Jun 13, 2024
@zhztheplayer zhztheplayer changed the title [VL] Support libraryloader on RedHat-9 [GLUTEN-6064][VL] Support libraryloader on RedHat-9 Jun 13, 2024
Copy link

#6064

@deepashreeraghu
Copy link
Contributor Author

deepashreeraghu commented Jun 14, 2024

@surnaik - Thanks for reviewing and approval.
I see that even after approval this PR is blocked. Please let me know of any pending action from my end.

@deepashreeraghu
Copy link
Contributor Author

@PHILO-HE - Could you please help here?

@PHILO-HE
Copy link
Contributor

I see that even after approval this PR is blocked. Please let me know of any pending action from my end.

New contributor's first PR needs committer's approval for running CI. Just approved.

@deepashreeraghu, did you test this patch on redhat 9?

@deepashreeraghu
Copy link
Contributor Author

Yes @PHILO-HE. I built Gluten on centos8 and wanted to try it on RHEL9. The first road block I hit into was it was not allowing to proceed due to this condition. After fixing this I was able to proceed and run a simple wordcount on RHEL9 with the jar built on centos8.
I have not run TPCDS or TPCH yet.

@PHILO-HE PHILO-HE changed the title [GLUTEN-6064][VL] Support libraryloader on RedHat-9 [GLUTEN-6064][VL] Support loading shared libraries on RedHat-9 Jun 19, 2024
@PHILO-HE PHILO-HE merged commit d7b978d into apache:main Jun 19, 2024
37 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_6063_time.csv log/native_master_06_18_2024_800cadd0f_time.csv difference percentage
q1 36.47 34.68 -1.787 95.10%
q2 23.80 27.07 3.274 113.76%
q3 41.29 38.23 -3.058 92.59%
q4 32.66 36.14 3.483 110.67%
q5 68.53 71.13 2.598 103.79%
q6 9.86 7.39 -2.476 74.89%
q7 80.92 84.79 3.877 104.79%
q8 85.08 84.78 -0.295 99.65%
q9 121.54 117.48 -4.062 96.66%
q10 47.70 45.02 -2.681 94.38%
q11 20.60 22.82 2.228 110.82%
q12 28.84 27.15 -1.684 94.16%
q13 38.13 39.59 1.458 103.82%
q14 18.11 18.08 -0.034 99.81%
q15 31.29 30.03 -1.265 95.96%
q16 14.23 13.98 -0.253 98.22%
q17 105.72 103.10 -2.619 97.52%
q18 147.90 144.12 -3.784 97.44%
q19 13.84 13.72 -0.117 99.16%
q20 29.06 26.04 -3.026 89.59%
q21 261.95 263.69 1.738 100.66%
q22 12.18 12.17 -0.013 99.89%
total 1269.70 1261.21 -8.496 99.33%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants