Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

[HIVEMALL-85] Upgrade hivemall-xgboost's hadoop version to 2.6.5 #59

Closed
wants to merge 1 commit into from
Closed

[HIVEMALL-85] Upgrade hivemall-xgboost's hadoop version to 2.6.5 #59

wants to merge 1 commit into from

Conversation

wangyum
Copy link
Member

@wangyum wangyum commented Mar 4, 2017

What changes were proposed in this pull request?

Upgrade hivemall-xgboost's hadoop version to 2.6.5

What type of PR is it?

Improvement

What is the Jira issue?

HIVEMALL-85

How was this patch tested?

manual tests

@maropu
Copy link
Member

maropu commented Mar 4, 2017

@wangyum Thanks for your continuous contributions!
@myui Do we have any reason to have a dependency with hadoop-core 0.20.2-cdh3u6? I just used this dependency along with the other modules.

$find . -type f | grep pom.xml | xargs grep cdh
./core/pom.xml:                 <version>0.20.2-cdh3u6</version>
./mixserv/pom.xml:                      <version>0.20.2-cdh3u6</version>
./nlp/pom.xml:                  <version>0.20.2-cdh3u6</version>
./spark/spark-common/pom.xml:                   <version>0.20.2-cdh3u6</version>

@myui
Copy link
Member

myui commented Mar 4, 2017

@wangyum @maropu I think it's provided maven space and thus no need to change.
provided scope libraries are used just for compiling and not bundled in jars.

@maropu
Copy link
Member

maropu commented Mar 5, 2017

Yea, I know, but I know the reason why we use cdh instead of hadoop community version?

@myui
Copy link
Member

myui commented Mar 5, 2017

Mostly for historical reasons. Better to change the version dependencies to Hadoop v2.4.0 (not v2.6.x) but dependencies packages change and careful verification is required.

This branch changed the dependencies to v2.4.0
https://github.com/myui/hivemall/tree/dev/yarnkit

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 37.03% when pulling 66b6be5 on wangyum:HIVEMALL-85 into 1cccf66 on apache:master.

@coveralls
Copy link

coveralls commented Mar 5, 2017

Coverage Status

Coverage remained the same at 36.739% when pulling 66b6be5 on wangyum:HIVEMALL-85 into 1cccf66 on apache:master.

@maropu
Copy link
Member

maropu commented Mar 5, 2017

@wangyum Why you select 2.6.5 in this pr? Any reason?

@wangyum
Copy link
Member Author

wangyum commented Mar 5, 2017

@myui
Copy link
Member

myui commented Mar 5, 2017

We need to change whole dependencies to v2.4.0 following the way in https://github.com/myui/hivemall/tree/dev/yarnkit

Filed a ticket https://issues.apache.org/jira/browse/HIVEMALL-86

I would like to move the discussions to Hivemall-86.

@wangyum Could you close this pull request?

@wangyum
Copy link
Member Author

wangyum commented Mar 5, 2017

OK

@wangyum wangyum closed this Mar 5, 2017
@wangyum wangyum deleted the HIVEMALL-85 branch March 5, 2017 12:39
@myui
Copy link
Member

myui commented Mar 5, 2017

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants