Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

[HIVEMALL-84-2] Fix docker #74

Merged
merged 4 commits into from
Apr 28, 2017
Merged

[HIVEMALL-84-2] Fix docker #74

merged 4 commits into from
Apr 28, 2017

Conversation

amaya382
Copy link
Member

@amaya382 amaya382 commented Apr 25, 2017

What changes were proposed in this pull request?

Fix docker (#68 (comment))

What type of PR is it?

Bug Fix

What is the Jira issue?

HIVEMALL-84

How was this patch tested?

manual tests

@coveralls
Copy link

coveralls commented Apr 25, 2017

Coverage Status

Coverage remained the same at 37.962% when pulling ede6c9d on amaya382:fix-docker into bffd2c7 on apache:master.

@myui
Copy link
Member

myui commented Apr 26, 2017

@amaya382 build of hivemall better to be optional in the document. Provide ready-to-use jars in the docker image.

I think Docker file should invoke bin/build.sh to create jars before ln -s.
https://github.com/apache/incubator-hivemall/blob/master/resources/docker/Dockerfile#L45

@amaya382
Copy link
Member Author

amaya382 commented Apr 26, 2017

@myui I've wanted to write as option explicitly but it makes doc complex. because if use data volume (probably most frequent use case), building becomes a must. so in fact, it's necessary to build.
if distribute via dockerhub, we can divide use prebuild image (for users, don't need to build hivemall) and use from source (for developers, need to build hivemall), and can write easy document.
Wait for dockerhub support or not?

I think Docker file should invoke bin/build.sh to create jars before ln -s

what will change?

@myui
Copy link
Member

myui commented Apr 26, 2017

@amaya382

what will change?

${HIVEMALL_PATH}/target/hivemall-core-${HIVEMALL_VERSION}-with-dependencies.jar is missing before building hivemall.

@amaya382
Copy link
Member Author

Now blocked by HIVEMALL-100

@asfgit asfgit merged commit 3526bcf into apache:master Apr 28, 2017
asfgit pushed a commit that referenced this pull request Apr 28, 2017
@myui
Copy link
Member

myui commented Apr 28, 2017

@amaya382 Merged with modifications. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants