Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

feat: support multiple cluster #172

Merged
merged 4 commits into from
May 15, 2023

Conversation

ZuLiangWang
Copy link
Contributor

@ZuLiangWang ZuLiangWang commented May 9, 2023

Which issue does this PR close?

Closes #

Rationale for this change

In order to avoid having to build a new CeresMeta cluster every time a new CeresDB cluster is created, we need to support the feature of one CeresMeta cluster managing multiple CeresDB clusters.

What changes are included in this PR?

  • Support create new CeresDB cluster & update cluster config & list clusters by http interface.
  • Persist the enableSchedule and topologyType fields.
  • To support cluster-level log output, create a child logger for each cluster.

Are there any user-facing changes?

None.

How does this change test

Pass all unit tests and local manual tests.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #172 (8f0fc6f) into main (7f1354e) will decrease coverage by 0.58%.
The diff coverage is 20.54%.

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   39.66%   39.08%   -0.58%     
==========================================
  Files          34       34              
  Lines        4213     4306      +93     
==========================================
+ Hits         1671     1683      +12     
- Misses       2317     2398      +81     
  Partials      225      225              
Impacted Files Coverage Δ
server/cluster/metadata/cluster_metadata.go 0.00% <0.00%> (ø)
server/cluster/metadata/table_manager.go 0.00% <0.00%> (ø)
server/cluster/metadata/topology_manager.go 0.00% <0.00%> (ø)
server/cluster/metadata/types.go 0.00% <0.00%> (ø)
server/coordinator/factory.go 4.45% <0.00%> (ø)
server/coordinator/procedure/manager_impl.go 0.00% <0.00%> (ø)
server/storage/meta.go 0.00% <ø> (ø)
server/storage/storage_impl.go 57.21% <0.00%> (-5.10%) ⬇️
server/id/id_impl.go 63.73% <75.00%> (ø)
server/storage/types.go 63.34% <77.41%> (-0.20%) ⬇️
... and 2 more

@ZuLiangWang ZuLiangWang force-pushed the feat-multiple-cluster branch 10 times, most recently from 137f1c2 to 4fdd11d Compare May 12, 2023 07:06
server/cluster/manager.go Outdated Show resolved Hide resolved
server/cluster/cluster.go Outdated Show resolved Hide resolved
server/cluster/manager.go Outdated Show resolved Hide resolved
server/cluster/metadata/cluster_metadata.go Outdated Show resolved Hide resolved
server/cluster/metadata/types.go Outdated Show resolved Hide resolved
server/service/http/api.go Outdated Show resolved Hide resolved
server/storage/storage_impl.go Outdated Show resolved Hide resolved
server/storage/types.go Outdated Show resolved Hide resolved
server/storage/types.go Outdated Show resolved Hide resolved
server/storage/types.go Show resolved Hide resolved
@ZuLiangWang ZuLiangWang force-pushed the feat-multiple-cluster branch 2 times, most recently from dfe33f3 to f372447 Compare May 15, 2023 06:10
server/cluster/manager.go Outdated Show resolved Hide resolved
server/service/http/api.go Outdated Show resolved Hide resolved
server/service/http/api.go Outdated Show resolved Hide resolved
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 45c4f10 into apache:main May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants