This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZuLiangWang
force-pushed
the
feat-multiple-cluster
branch
from
May 10, 2023 03:24
225c1b4
to
3fa1a90
Compare
Codecov Report
@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 39.66% 39.08% -0.58%
==========================================
Files 34 34
Lines 4213 4306 +93
==========================================
+ Hits 1671 1683 +12
- Misses 2317 2398 +81
Partials 225 225
|
ZuLiangWang
force-pushed
the
feat-multiple-cluster
branch
10 times, most recently
from
May 12, 2023 07:06
137f1c2
to
4fdd11d
Compare
chunshao90
reviewed
May 12, 2023
ZuLiangWang
force-pushed
the
feat-multiple-cluster
branch
from
May 15, 2023 02:32
4fdd11d
to
2c40256
Compare
ZuLiangWang
force-pushed
the
feat-multiple-cluster
branch
2 times, most recently
from
May 15, 2023 06:10
dfe33f3
to
f372447
Compare
ZuLiangWang
force-pushed
the
feat-multiple-cluster
branch
from
May 15, 2023 06:12
f372447
to
fa61a22
Compare
chunshao90
reviewed
May 15, 2023
chunshao90
reviewed
May 15, 2023
ZuLiangWang
force-pushed
the
feat-multiple-cluster
branch
from
May 15, 2023 09:15
4aa0480
to
8f0fc6f
Compare
chunshao90
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
In order to avoid having to build a new CeresMeta cluster every time a new CeresDB cluster is created, we need to support the feature of one CeresMeta cluster managing multiple CeresDB clusters.
What changes are included in this PR?
Are there any user-facing changes?
None.
How does this change test
Pass all unit tests and local manual tests.