Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine the hg-style.xml specification #2436

Closed
wants to merge 2 commits into from
Closed

Conversation

msgui
Copy link
Contributor

@msgui msgui commented Feb 1, 2024

Purpose of the PR

subtask of #2435

Main Changes

image
👉: https://github.com/apache/incubator-hugegraph/wiki/HugeGraph-Code-Style-Guide
Add the option 'BLANK_LINES_AFTER_CLASS_HEADER' with a value of 1.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ci-cd Build or deploy labels Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d4532c) 66.23% compared to head (01f4ff0) 63.85%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2436      +/-   ##
============================================
- Coverage     66.23%   63.85%   -2.39%     
  Complexity      828      828              
============================================
  Files           511      511              
  Lines         42597    42597              
  Branches       5942     5942              
============================================
- Hits          28215    27200    -1015     
- Misses        11566    12652    +1086     
+ Partials       2816     2745      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot modified the milestones: 1.3.0, 1.5.0 Feb 2, 2024
@msgui msgui changed the title chore: update style.xml chore: refine the hg-style.xml specification Feb 7, 2024
@msgui msgui closed this Feb 8, 2024
@dosubot dosubot bot removed this from the 1.5.0 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build or deploy size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant