Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(server): enhance the storage path in RocksDB & clean code #2491

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Mar 21, 2024

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@imbajin imbajin added this to the 1.3.0 milestone Mar 21, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working rocksdb RocksDB backend labels Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 65.47619% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 66.27%. Comparing base (277f76e) to head (30fc04a).

Files Patch % Lines
...apache/hugegraph/security/HugeSecurityManager.java 63.88% 4 Missing and 9 partials ⚠️
...ain/java/org/apache/hugegraph/util/Reflection.java 41.17% 9 Missing and 1 partial ⚠️
...che/hugegraph/api/filter/AuthenticationFilter.java 0.00% 3 Missing ⚠️
...rg/apache/hugegraph/auth/HugeFactoryAuthProxy.java 88.46% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             master    #2491    +/-   ##
==========================================
  Coverage     66.26%   66.27%            
- Complexity      827      982   +155     
==========================================
  Files           511      511            
  Lines         42631    42649    +18     
  Branches       5948     5942     -6     
==========================================
+ Hits          28251    28267    +16     
- Misses        11557    11571    +14     
+ Partials       2823     2811    -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin changed the title fix: multi graph error in rocksdb with same path/fd refact(server): enhance the storage path in RocksDB & clean code Mar 21, 2024
@imbajin imbajin force-pushed the fix-auth branch 6 times, most recently from 313d1fa to fb5f5bb Compare March 21, 2024 13:41
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 22, 2024
@imbajin imbajin merged commit 6a4041e into master Mar 22, 2024
20 of 21 checks passed
@imbajin imbajin deleted the fix-auth branch March 22, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer rocksdb RocksDB backend size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants