Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): avoid overriding backend config in gremlin example script #2519

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

VGalaxies
Copy link
Contributor

@VGalaxies VGalaxies commented Apr 12, 2024

fixup #2518, I noticed that the gremlin example script is also used when importing example graphs, so users should be advised to manually configure the backend to memory.

Corresponding documentation PR -> apache/incubator-hugegraph-doc#354

@VGalaxies VGalaxies requested a review from imbajin April 12, 2024 11:52
@VGalaxies VGalaxies self-assigned this Apr 12, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working gremlin TinkerPop gremlin labels Apr 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.10%. Comparing base (3783247) to head (1e5f5ec).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2519   +/-   ##
=========================================
  Coverage     61.09%   61.10%           
  Complexity      827      827           
=========================================
  Files           579      579           
  Lines         46232    46232           
  Branches       6275     6275           
=========================================
+ Hits          28245    28249    +4     
+ Misses        15175    15168    -7     
- Partials       2812     2815    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 13, 2024
@imbajin imbajin merged commit 6be7569 into master Apr 14, 2024
14 checks passed
@imbajin imbajin deleted the fix-gremlin branch April 14, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gremlin TinkerPop gremlin lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants