Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BXMSDOC-6058-master: Update built-in FEEL adoc file to align with docs. #3067

Merged
merged 2 commits into from
Sep 1, 2020
Merged

BXMSDOC-6058-master: Update built-in FEEL adoc file to align with docs. #3067

merged 2 commits into from
Sep 1, 2020

Conversation

sterobin
Copy link
Contributor

@tarilabs , ready for your review. Applied changes from docs PR https://github.com/kiegroup/kie-docs/pull/2790.

Links:

@sterobin
Copy link
Contributor Author

sterobin commented Aug 28, 2020 •
edited

@kiegroup/gatekeepers , ready for merge.

@tarilabs
Copy link
Member

@sterobin let's wait for Linux... tasks to complete

@tarilabs
Copy link
Member

Some of the changes in the adoc is making fail org.kie.dmn.feel.documentation.ADocFEELExamplesTest.org.kie.dmn.feel.documentation.ADocFEELExamplesTest I need to jump on this, investigating...

@tarilabs
Make it passing the TEST (#1)
4019a3e 
* Align to new DOC format (list troubles AST processing)

* fix example
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@sterobin
Copy link
Contributor Author

@kiegroup/gatekeepers @tarilabs Looks like all green enough now, correct?

@tarilabs
Copy link
Member

I concur @sterobin ; @kiegroup/gatekeepers please merge with squash

@mariofusco mariofusco merged commit dda63d0 into apache:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarilabs tarilabs tarilabs approved these changes

@hellowdan hellowdan hellowdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sterobin @tarilabs @hellowdan @mariofusco