Skip to content

Commit 01364e5

Browse files
yanghuapan3793
authored andcommitted
[KYUUBI #1578] Introduce flink-sql-client dependency to reduce some duplicated code
…uplicated code <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #1584 from yanghua/KYUUBI-1578. Closes #1578 90c2f89 [yanghua] [KYUUBI #1578] Introduce flink-sql-client dependency to reduce some duplicated code Authored-by: yanghua <yanghua1127@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
1 parent b2e679d commit 01364e5

File tree

12 files changed

+20
-1056
lines changed

12 files changed

+20
-1056
lines changed

externals/kyuubi-flink-sql-engine/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,12 @@
7070
<scope>provided</scope>
7171
</dependency>
7272

73+
<dependency>
74+
<groupId>org.apache.flink</groupId>
75+
<artifactId>flink-sql-client_${scala.binary.version}</artifactId>
76+
<scope>provided</scope>
77+
</dependency>
78+
7379
<dependency>
7480
<groupId>org.apache.flink</groupId>
7581
<artifactId>flink-table-common</artifactId>

externals/kyuubi-flink-sql-engine/src/main/java/org/apache/kyuubi/engine/flink/config/EngineEnvironment.java

Lines changed: 0 additions & 81 deletions
This file was deleted.

externals/kyuubi-flink-sql-engine/src/main/java/org/apache/kyuubi/engine/flink/config/entries/ConfigEntry.java

Lines changed: 0 additions & 68 deletions
This file was deleted.

0 commit comments

Comments
 (0)