[KYUUBI #3012] Remove unused thrift request max attempts and related ut

### _Why are the changes needed?_

After #2948 and #2953, the OPERATION_THRIFT_CLIENT_REQUEST_MAX_ATTEMPTS is not used.

In this pr, I remove the attempts config entry and related ut that based on the request attempts.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #3012 from turboFei/follow_up_engine_alive.

Closes #3012

3d15e44 [Fei Wang] remove deprecated docs
89c9f2c [Fei Wang] remove docs
edb6ff2 [Fei Wang] remove ut
696bd85 [Fei Wang] saev
f91c61b [Fei Wang] remove unused attempt

Authored-by: Fei Wang <fwang12@ebay.com>
Signed-off-by: Fei Wang <fwang12@ebay.com>

Author: turboFei

docs/deployment/settings.md

@@ -395,9 +395,7 @@ kyuubi.operation.query.timeout|<undefined>|Timeout for query executions at
 kyuubi.operation.result.max.rows|0|Max rows of Spark query results. Rows that exceeds the limit would be ignored. By setting this value to 0 to disable the max rows limit.|int|1.6.0
 kyuubi.operation.scheduler.pool|<undefined>|The scheduler pool of job. Note that, this config should be used after change Spark config spark.scheduler.mode=FAIR.|string|1.1.1
 kyuubi.operation.spark.listener.enabled|true|When set to true, Spark engine registers a SQLOperationListener before executing the statement, logs a few summary statistics when each stage completes.|boolean|1.6.0
-kyuubi.operation.status.polling.max.attempts|5|(deprecated) - Using kyuubi.operation.thrift.client.request.max.attempts instead|int|1.4.0
 kyuubi.operation.status.polling.timeout|PT5S|Timeout(ms) for long polling asynchronous running sql query's status|duration|1.0.0
-kyuubi.operation.thrift.client.request.max.attempts|5|Max attempts for operation thrift request call at server-side on raw transport failures, e.g. TTransportException|int|1.6.0
 
 
 ### Server

kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala

@@ -1154,23 +1154,6 @@ object KyuubiConf {
       .timeConf
       .createWithDefault(Duration.ofSeconds(5).toMillis)
 
-  @deprecated(s"using kyuubi.operation.thrift.client.request.max.attempts instead", "1.6.0")
-  val OPERATION_STATUS_POLLING_MAX_ATTEMPTS: ConfigEntry[Int] =
-    buildConf("kyuubi.operation.status.polling.max.attempts")
-      .doc(s"(deprecated) - Using kyuubi.operation.thrift.client.request.max.attempts instead")
-      .version("1.4.0")
-      .intConf
-      .createWithDefault(5)
-
-  val OPERATION_THRIFT_CLIENT_REQUEST_MAX_ATTEMPTS: ConfigEntry[Int] =
-    buildConf("kyuubi.operation.thrift.client.request.max.attempts")
-      .doc("Max attempts for operation thrift request call at server-side on raw transport" +
-        " failures, e.g. TTransportException")
-      .version("1.6.0")
-      .intConf
-      .checkValue(_ > 0, "must be positive number")
-      .createWithDefault(5)
-
   val OPERATION_FORCE_CANCEL: ConfigEntry[Boolean] =
     buildConf("kyuubi.operation.interrupt.on.cancel")
       .doc("When true, all running tasks will be interrupted if one cancels a query. " +

kyuubi-server/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala

@@ -41,7 +41,6 @@ import org.apache.kyuubi.util.{ThreadUtils, ThriftUtils}
 
 class KyuubiSyncThriftClient private (
     protocol: TProtocol,
-    maxAttempts: Int,
     engineAliveProbeProtocol: Option[TProtocol],
     engineAliveProbeInterval: Long,
     engineAliveTimeout: Long)
@@ -458,7 +457,6 @@ private[kyuubi] object KyuubiSyncThriftClient extends Logging {
       conf: KyuubiConf): KyuubiSyncThriftClient = {
     val passwd = Option(password).filter(_.nonEmpty).getOrElse("anonymous")
     val loginTimeout = conf.get(ENGINE_LOGIN_TIMEOUT).toInt
-    val requestMaxAttempts = conf.get(KyuubiConf.OPERATION_THRIFT_CLIENT_REQUEST_MAX_ATTEMPTS)
     val aliveProbeEnabled = conf.get(KyuubiConf.ENGINE_ALIVE_PROBE_ENABLED)
     val aliveProbeInterval = conf.get(KyuubiConf.ENGINE_ALIVE_PROBE_INTERVAL).toInt
     val aliveTimeout = conf.get(KyuubiConf.ENGINE_ALIVE_TIMEOUT)
@@ -473,7 +471,6 @@ private[kyuubi] object KyuubiSyncThriftClient extends Logging {
       }
     new KyuubiSyncThriftClient(
       tProtocol,
-      requestMaxAttempts,
       aliveProbeProtocol,
       aliveProbeInterval,
       aliveTimeout)

kyuubi-server/src/test/scala/org/apache/kyuubi/operation/KyuubiOperationPerConnectionSuite.scala

@@ -210,35 +210,6 @@ class KyuubiOperationPerConnectionSuite extends WithKyuubiServer with HiveJDBCTe
       assert(kyuubiConnection.isClosed)
     }
   }
-
-  test("KYUUBI #2102 - support engine alive probe to fast fail on engine broken") {
-    withSessionConf(Map(
-      KyuubiConf.ENGINE_ALIVE_PROBE_ENABLED.key -> "true",
-      KyuubiConf.ENGINE_ALIVE_PROBE_INTERVAL.key -> "1000",
-      KyuubiConf.ENGINE_ALIVE_TIMEOUT.key -> "3000",
-      KyuubiConf.OPERATION_THRIFT_CLIENT_REQUEST_MAX_ATTEMPTS.key -> "10000"))(Map.empty)(
-      Map.empty) {
-      withSessionHandle { (client, handle) =>
-        val preReq = new TExecuteStatementReq()
-        preReq.setStatement("select engine_name()")
-        preReq.setSessionHandle(handle)
-        preReq.setRunAsync(false)
-        client.ExecuteStatement(preReq)
-
-        val executeStmtReq = new TExecuteStatementReq()
-        executeStmtReq.setStatement("select java_method('java.lang.System', 'exit', 1)")
-        executeStmtReq.setSessionHandle(handle)
-        executeStmtReq.setRunAsync(false)
-        val startTime = System.currentTimeMillis()
-        val executeStmtResp = client.ExecuteStatement(executeStmtReq)
-        assert(executeStmtResp.getStatus.getStatusCode === TStatusCode.ERROR_STATUS)
-        assert(executeStmtResp.getStatus.getErrorMessage contains
-          "Caused by: java.net.SocketException: Connection reset")
-        val elapsedTime = System.currentTimeMillis() - startTime
-        assert(elapsedTime > 3 * 1000 && elapsedTime < 20 * 1000)
-      }
-    }
-  }
 }
 
 class TestSessionConfAdvisor extends SessionConfAdvisor {

kyuubi-server/src/test/scala/org/apache/kyuubi/operation/KyuubiOperationPerUserSuite.scala

@@ -161,8 +161,7 @@ class KyuubiOperationPerUserSuite extends WithKyuubiServer with SparkQueryTests
       withSessionConf(Map(
         KyuubiConf.ENGINE_ALIVE_PROBE_ENABLED.key -> "true",
         KyuubiConf.ENGINE_ALIVE_PROBE_INTERVAL.key -> "1000",
-        KyuubiConf.ENGINE_ALIVE_TIMEOUT.key -> "3000",
-        KyuubiConf.OPERATION_THRIFT_CLIENT_REQUEST_MAX_ATTEMPTS.key -> "10000"))(Map.empty)(
+        KyuubiConf.ENGINE_ALIVE_TIMEOUT.key -> "1000"))(Map.empty)(
         Map.empty) {
         withSessionHandle { (client, handle) =>
           val preReq = new TExecuteStatementReq()