Skip to content

Commit 2f1f258

Browse files
iodoneyaooqinn
authored andcommitted
[KYUUBI #1678] Fixed: The value of hasResultSet is always set to true in Kyuubi Server
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> Fixes #1678 ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> Updating `hasResultSet` state which is determined by the remote service ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #1682 from iodone/kyuubi-1678. Closes #1678 8e55385 [odone] comment Authored-by: odone <odone.zhang@gmail.com> Signed-off-by: Kent Yao <yao@apache.org>
1 parent e0d9458 commit 2f1f258

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

kyuubi-server/src/main/scala/org/apache/kyuubi/operation/ExecuteStatement.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ class ExecuteStatement(
6969
// in thrift protocol, in sync mode, we cannot distinguish between long-run query and
7070
// engine crash without response before socket read timeout.
7171
_remoteOpHandle = client.executeStatement(statement, true, queryTimeout)
72+
setHasResultSet(_remoteOpHandle.isHasResultSet)
7273
} catch onError()
7374
}
7475

0 commit comments

Comments
 (0)