Skip to content

Commit 3323bae

Browse files
pan3793turboFei
authored andcommitted
[KYUUBI #1855] Suppress logging to console in scalatest
### _Why are the changes needed?_ This change recovers the previous behavior, writing logs to `target/unit-tests.log` instead of print log to console in scalatest. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #1855 from pan3793/debug. Closes #1855 a6ea4e4 [Cheng Pan] Suppress logging to console in scalatest Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Fei Wang <fwang12@ebay.com>
1 parent 0e45a4b commit 3323bae

File tree

15 files changed

+71
-14
lines changed

15 files changed

+71
-14
lines changed

dev/kyuubi-extension-spark-3-1/src/test/resources/log4j2.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
3030
appender.console.filter.1.type = Filters
3131

3232
appender.console.filter.1.a.type = ThresholdFilter
33-
appender.console.filter.1.a.level = debug
33+
appender.console.filter.1.a.level = fatal
3434

3535
# SPARK-34128: Suppress undesirable TTransportException warnings, due to THRIFT-4805
3636
appender.console.filter.1.b.type = RegexFilter

dev/kyuubi-extension-spark-3-2/src/test/resources/log4j2.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
3030
appender.console.filter.1.type = Filters
3131

3232
appender.console.filter.1.a.type = ThresholdFilter
33-
appender.console.filter.1.a.level = debug
33+
appender.console.filter.1.a.level = fatal
3434

3535
# SPARK-34128: Suppress undesirable TTransportException warnings, due to THRIFT-4805
3636
appender.console.filter.1.b.type = RegexFilter

dev/kyuubi-extension-spark-common/src/test/resources/log4j2.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
3030
appender.console.filter.1.type = Filters
3131

3232
appender.console.filter.1.a.type = ThresholdFilter
33-
appender.console.filter.1.a.level = debug
33+
appender.console.filter.1.a.level = fatal
3434

3535
# SPARK-34128: Suppress undesirable TTransportException warnings, due to THRIFT-4805
3636
appender.console.filter.1.b.type = RegexFilter

externals/kyuubi-flink-sql-engine/src/test/resources/log4j2.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
3030
appender.console.filter.1.type = Filters
3131

3232
appender.console.filter.1.a.type = ThresholdFilter
33-
appender.console.filter.1.a.level = debug
33+
appender.console.filter.1.a.level = fatal
3434

3535
# SPARK-34128: Suppress undesirable TTransportException warnings, due to THRIFT-4805
3636
appender.console.filter.1.b.type = RegexFilter

externals/kyuubi-spark-sql-engine/src/test/resources/log4j2.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
3030
appender.console.filter.1.type = Filters
3131

3232
appender.console.filter.1.a.type = ThresholdFilter
33-
appender.console.filter.1.a.level = debug
33+
appender.console.filter.1.a.level = fatal
3434

3535
# SPARK-34128: Suppress undesirable TTransportException warnings, due to THRIFT-4805
3636
appender.console.filter.1.b.type = RegexFilter

externals/kyuubi-trino-engine/src/test/resources/log4j2.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
3030
appender.console.filter.1.type = Filters
3131

3232
appender.console.filter.1.a.type = ThresholdFilter
33-
appender.console.filter.1.a.level = debug
33+
appender.console.filter.1.a.level = fatal
3434

3535
# SPARK-34128: Suppress undesirable TTransportException warnings, due to THRIFT-4805
3636
appender.console.filter.1.b.type = RegexFilter
Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
#
2+
# Licensed to the Apache Software Foundation (ASF) under one or more
3+
# contributor license agreements. See the NOTICE file distributed with
4+
# this work for additional information regarding copyright ownership.
5+
# The ASF licenses this file to You under the Apache License, Version 2.0
6+
# (the "License"); you may not use this file except in compliance with
7+
# the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
#
17+
18+
# Set everything to be logged to the file target/unit-tests.log
19+
rootLogger.level = debug
20+
rootLogger.appenderRef.stdout.ref = STDOUT
21+
rootLogger.appenderRef.file.ref = File
22+
23+
# Console Appender
24+
appender.console.type = Console
25+
appender.console.name = STDOUT
26+
appender.console.target = SYSTEM_OUT
27+
appender.console.layout.type = PatternLayout
28+
appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
29+
30+
appender.console.filter.1.type = Filters
31+
32+
appender.console.filter.1.a.type = ThresholdFilter
33+
appender.console.filter.1.a.level = fatal
34+
35+
# SPARK-34128: Suppress undesirable TTransportException warnings, due to THRIFT-4805
36+
appender.console.filter.1.b.type = RegexFilter
37+
appender.console.filter.1.b.regex = .*Thrift error occurred during processing of message.*
38+
appender.console.filter.1.b.onMatch = deny
39+
appender.console.filter.1.b.onMismatch = neutral
40+
41+
# File Appender
42+
appender.file.type = File
43+
appender.file.name = File
44+
appender.file.fileName = target/unit-tests.log
45+
appender.file.layout.type = PatternLayout
46+
appender.file.layout.pattern = %d{HH:mm:ss.SSS} %t %p %c{1}: %m%n
47+
48+
appender.file.filter.1.type = Filters
49+
50+
appender.file.filter.1.a.type = RegexFilter
51+
appender.file.filter.1.a.regx = .*Thrift error occurred during processing of message.*
52+
appender.file.filter.1.a.onMatch = deny
53+
appender.file.filter.1.a.onMismatch = neutral
54+
55+
# Set the logger level of File Appender to DEBUG
56+
appender.file.filter.1.b.type = ThresholdFilter
57+
appender.file.filter.1.b.level = debug

integration-tests/kyuubi-kubernetes-deployment-it/src/test/resources/log4j2.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
3030
appender.console.filter.1.type = Filters
3131

3232
appender.console.filter.1.a.type = ThresholdFilter
33-
appender.console.filter.1.a.level = debug
33+
appender.console.filter.1.a.level = fatal
3434

3535
# SPARK-34128: Suppress undesirable TTransportException warnings, due to THRIFT-4805
3636
appender.console.filter.1.b.type = RegexFilter

kyuubi-common/src/main/resources/log4j2-defaults.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
2929
appender.console.filter.1.type = Filters
3030

3131
appender.console.filter.1.a.type = ThresholdFilter
32-
appender.console.filter.1.a.level = debug
32+
appender.console.filter.1.a.level = fatal
3333

3434
# SPARK-34128: Suppress undesirable TTransportException warnings, due to THRIFT-4805
3535
appender.console.filter.1.b.type = RegexFilter

kyuubi-common/src/test/resources/log4j2.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
3030
appender.console.filter.1.type = Filters
3131

3232
appender.console.filter.1.a.type = ThresholdFilter
33-
appender.console.filter.1.a.level = debug
33+
appender.console.filter.1.a.level = fatal
3434

3535
# SPARK-34128: Suppress undesirable TTransportException warnings, due to THRIFT-4805
3636
appender.console.filter.1.b.type = RegexFilter

0 commit comments

Comments
 (0)