Skip to content

Commit 3942cf3

Browse files
turboFeiulysses-you
authored andcommitted
[KYUUBI #1541] Remove keys sync step for Kyuubi finalize release
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> Remove keys sync step for Kyuubi finalize release. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #1541 from turboFei/remove_keys_sync. Closes #1541 79a4925 [Fei Wang] Remove unused keys sync step for kyuubi finalize release Authored-by: Fei Wang <fwang12@ebay.com> Signed-off-by: ulysses-you <ulyssesyou@apache.org>
1 parent 2f46d4c commit 3942cf3

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

build/release/release.sh

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ set -x
2323

2424
ASF_USERNAME=${ASF_USERNAME:?"ASF_USERNAME is required"}
2525
ASF_PASSWORD=${ASF_PASSWORD:?"ASF_PASSWORD is required"}
26-
RELEASE_VERSION=${RELEASE_VERSION:?"RELEASE_VERSION is required"}
27-
RELEASE_RC_NO=${RELEASE_RC_NO:?"RELEASE_RC_NO is required"}
26+
RELEASE_VERSION=${RELEASE_VERSION:?"RELEASE_VERSION is required, e.g. 1.4.0-incubating"}
27+
RELEASE_RC_NO=${RELEASE_RC_NO:?"RELEASE_RC_NO is required, e.g. 0"}
2828

2929
exit_with_usage() {
3030
local NAME=$(basename $0)
@@ -110,16 +110,6 @@ finalize_svn() {
110110
--message "Apache Kyuubi ${RELEASE_VERSION}" \
111111
"${SVN_STAGING_REPO}/${RELEASE_TAG}" "${SVN_RELEASE_REPO}/kyuubi-${RELEASE_VERSION}"
112112
echo "Kyuubi tarballs moved"
113-
114-
echo "Sync'ing KEYS"
115-
svn checkout --depth=files "${SVN_RELEASE_REPO}" "${SVN_RELEASE_DIR}"
116-
curl "${SVN_STAGING_REPO}/KEYS" > "${SVN_RELEASE_DIR}/KEYS"
117-
svn add "${SVN_RELEASE_DIR}/KEYS"
118-
(
119-
cd "${SVN_RELEASE_DIR}" && \
120-
svn commit --username "${ASF_USERNAME}" --password "${ASF_PASSWORD}" --message "Update KEYS"
121-
)
122-
echo "KEYS sync'ed"
123113
}
124114

125115
if [[ "$1" == "publish" ]]; then

0 commit comments

Comments
 (0)