Skip to content

Commit 5f04aa6

Browse files
zwangshengulysses-you
authored andcommitted
[KYUUBI #2410] [Improvement] Fix docker-image-tool.sh example version to 1.4.0
### _Why are the changes needed?_ `docker-image-tools.sh` should use the version where the script was added as the trial version. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2410 from zwangsheng/bug/fix_docker_image_build_usage. Closes #2410 f32ef8e [zwangsheng] fix version Authored-by: zwangsheng <2213335496@qq.com> Signed-off-by: ulysses-you <ulyssesyou@apache.org>
1 parent 45e5eda commit 5f04aa6

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

bin/docker-image-tool.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -208,12 +208,12 @@ Examples:
208208
$0 -r docker.io/myrepo -t v1.4.0 build
209209
$0 -r docker.io/myrepo -t v1.4.0 push
210210
211-
- Build and push with tag "v3.0.0" and Spark-3.2.1 as base image to docker.io/myrepo
212-
$0 -r docker.io/myrepo -t v3.0.0 -b BASE_IMAGE=repo/spark:3.2.1 build
213-
$0 -r docker.io/myrepo -t v3.0.0 push
211+
- Build and push with tag "v1.4.0" and Spark-3.2.1 as base image to docker.io/myrepo
212+
$0 -r docker.io/myrepo -t v1.4.0 -b BASE_IMAGE=repo/spark:3.2.1 build
213+
$0 -r docker.io/myrepo -t v1.4.0 push
214214
215215
- Build and push for multiple archs to docker.io/myrepo
216-
$0 -r docker.io/myrepo -t v3.0.0 -X build
216+
$0 -r docker.io/myrepo -t v1.4.0 -X build
217217
218218
# Note: buildx, which does cross building, needs to do the push during build
219219
# So there is no separate push step with -X

docs/deployment/kyuubi_on_kubernetes.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ Examples:
4747
$0 -r docker.io/myrepo -t v1.4.0 build
4848
$0 -r docker.io/myrepo -t v1.4.0 push
4949

50-
- Build and push with tag "v3.0.0" and Spark-3.2.1 as base image to docker.io/myrepo
51-
$0 -r docker.io/myrepo -t v3.0.0 -b BASE_IMAGE=repo/spark:3.2.1 build
52-
$0 -r docker.io/myrepo -t v3.0.0 push
50+
- Build and push with tag "v1.4.0" and Spark-3.2.1 as base image to docker.io/myrepo
51+
$0 -r docker.io/myrepo -t v1.4.0 -b BASE_IMAGE=repo/spark:3.2.1 build
52+
$0 -r docker.io/myrepo -t v1.4.0 push
5353

5454
- Build and push for multiple archs to docker.io/myrepo
55-
$0 -r docker.io/myrepo -t v3.0.0 -X build
55+
$0 -r docker.io/myrepo -t v1.4.0 -X build
5656

5757
- Build with Spark placed "/path/spark"
5858
$0 -s /path/spark build

0 commit comments

Comments
 (0)