Skip to content

Commit 825c70d

Browse files
lightning-LturboFei
authored andcommitted
[KYUUBI #2919] Fix typo and wording for JDBCMetadataStoreConf
### _Why are the changes needed?_ Fix typo and wording for JDBCMetadataStoreConf. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2919 from lightning-L/typo-1. Closes #2919 f02ffb8 [Tianlin Liao] fix typo and wording for JDBCMetadataStoreConf Authored-by: Tianlin Liao <tiliao@ebay.com> Signed-off-by: Fei Wang <fwang12@ebay.com>
1 parent f3610b2 commit 825c70d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

docs/deployment/settings.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ kyuubi.metadata.request.retry.queue.size|65536|The maximum queue size for buffer
350350
kyuubi.metadata.request.retry.threads|10|Number of threads in the metadata request retry manager thread pool. The metadata store might be unavailable sometimes and the requests will fail, to tolerant for this case and unblock the main thread, we support to retry the failed requests in async way.|int|1.6.0
351351
kyuubi.metadata.store.class|org.apache.kyuubi.server.metadata.jdbc.JDBCMetadataStore|Fully qualified class name for server metadata store.|string|1.6.0
352352
kyuubi.metadata.store.jdbc.database.schema.init|true|Whether to init the jdbc metadata store database schema.|boolean|1.6.0
353-
kyuubi.metadata.store.jdbc.database.type|DERBY|The database type for server jdbc metadata store.<ul> <li>DERBY: Apache Derby, jdbc driver `org.apache.derby.jdbc.AutoloadedDriver`.</li> <li>MYSQL: MySQL, jdbc driver `com.mysql.jdbc.Driver`.</li> <li>CUSTOM: User-defined database type, need specify the jdbc driver in addition.</li> Note that: The jdbc datasource is powered by HiKariCP, for datasource properties, please specify them with prefix: kyuubi.server.metadata.store.jdbc.datasource. For example, kyuubi.server.metadata.store.jdbc.datasource.connectionTimeout=10000.|string|1.6.0
353+
kyuubi.metadata.store.jdbc.database.type|DERBY|The database type for server jdbc metadata store.<ul> <li>DERBY: Apache Derby, jdbc driver `org.apache.derby.jdbc.AutoloadedDriver`.</li> <li>MYSQL: MySQL, jdbc driver `com.mysql.jdbc.Driver`.</li> <li>CUSTOM: User-defined database type, need to specify corresponding jdbc driver.</li> Note that: The jdbc datasource is powered by HiKariCP, for datasource properties, please specify them with prefix: kyuubi.metadata.store.jdbc.datasource. For example, kyuubi.metadata.store.jdbc.datasource.connectionTimeout=10000.|string|1.6.0
354354
kyuubi.metadata.store.jdbc.driver|&lt;undefined&gt;|JDBC driver class name for server jdbc metadata store.|string|1.6.0
355355
kyuubi.metadata.store.jdbc.password||The password for server jdbc metadata store.|string|1.6.0
356356
kyuubi.metadata.store.jdbc.url|jdbc:derby:memory:kyuubi_state_store_db;create=true|The jdbc url for server jdbc metadata store. By defaults, it is a DERBY in-memory database url, and the state information is not shared across kyuubi instances. To enable multiple kyuubi instances high available, please specify a production jdbc url.|string|1.6.0

kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStoreConf.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ object JDBCMetadataStoreConf {
4040
.doc("The database type for server jdbc metadata store.<ul>" +
4141
" <li>DERBY: Apache Derby, jdbc driver `org.apache.derby.jdbc.AutoloadedDriver`.</li>" +
4242
" <li>MYSQL: MySQL, jdbc driver `com.mysql.jdbc.Driver`.</li>" +
43-
" <li>CUSTOM: User-defined database type, need specify the jdbc driver in addition.</li>" +
43+
" <li>CUSTOM: User-defined database type, need to specify corresponding jdbc driver.</li>" +
4444
" Note that: The jdbc datasource is powered by HiKariCP, for datasource properties," +
45-
" please specify them with prefix: kyuubi.server.metadata.store.jdbc.datasource." +
46-
" For example, kyuubi.server.metadata.store.jdbc.datasource.connectionTimeout=10000.")
45+
" please specify them with prefix: kyuubi.metadata.store.jdbc.datasource." +
46+
" For example, kyuubi.metadata.store.jdbc.datasource.connectionTimeout=10000.")
4747
.version("1.6.0")
4848
.stringConf
4949
.transform(_.toUpperCase(Locale.ROOT))

0 commit comments

Comments
 (0)