Skip to content

Commit

Permalink
[KYUUBI #1726] Extract dep workflow to a single yml and disable it in…
Browse files Browse the repository at this point in the history
… other jobs

<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1726 from yaooqinn/dep2.

Closes #1726

c214c06 [Kent Yao] Extract dep workflow to a single yml and disable it in other jobs

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Kent Yao <yao@apache.org>
  • Loading branch information
yaooqinn committed Jan 11, 2022
1 parent 89689c0 commit b0d7dac
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/master.yml
Expand Up @@ -83,9 +83,6 @@ jobs:
uses: codecov/codecov-action@v2
with:
verbose: true
- name: Detected Dependency List Change
if: ${{ matrix.java == 8 }}
run: build/dependency.sh
- name: Upload test logs
if: failure()
uses: actions/upload-artifact@v2
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/style.yml
Expand Up @@ -27,8 +27,8 @@ on:
- branch-*

jobs:
lint-scala:
name: Scala style check
linter:
name: Style and Dep check
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
Expand All @@ -37,8 +37,11 @@ jobs:
with:
distribution: zulu
java-version: 8
- name: Server dependency check
run: build/dependency.sh
- name: Scalastyle with Maven
run: build/mvn scalastyle:check -Ptpcds -Pspark-block-cleaner -Pkubernetes -Pspark-3.1 -Pspark-3.2
- name: Upload scalastyle report
if: failure()
run: for log in `find * -name "scalastyle-output.xml"`; do echo "=========$log========="; grep "error" $log; done

0 comments on commit b0d7dac

Please sign in to comment.