Skip to content

Commit f60e9d4

Browse files
wForgetpan3793
authored andcommitted
[KYUUBI #1776][FOLLOWUP] Fill empty td tag for Failure Reason column in EngineTable
### _Why are the changes needed?_ Followup #1776 'Failure Reason' column needs to be filled with empty td tag when there is no exception: ![微信截图_20220812135529](https://user-images.githubusercontent.com/17894939/184293709-d2ae7cdd-5625-422d-b6d7-7368429cf600.png) ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [X] Add screenshots for manual tests if appropriate ![微信截图_20220812135453](https://user-images.githubusercontent.com/17894939/184293704-ab7613b2-28ea-4ac0-9aed-e5382251365d.png) - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #3223 from wForget/KYUUBI-1776-followup. Closes #1776 a83d000 [Wang Zhen] [KYUUBI-1776][FOLLOWUP] Fill empty td tag for `Failure Reason` column in EngineTable Authored-by: Wang Zhen <wangzhen07@qiyi.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
1 parent bbe7a4d commit f60e9d4

File tree

1 file changed

+3
-1
lines changed
  • externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui

1 file changed

+3
-1
lines changed

externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EnginePage.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,9 @@ private class StatementStatsPagedTable(
388388
}
389389
}
390390
</td>
391-
{if (event.exception.isDefined) errorMessageCell(event.exception.get.getMessage)}
391+
{
392+
if (event.exception.isDefined) errorMessageCell(event.exception.get.getMessage) else <td></td>
393+
}
392394
</tr>
393395
}
394396

0 commit comments

Comments
 (0)