Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include branch-0.8 modifications back to main branch #429

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dacort
Copy link
Contributor

@dacort dacort commented Oct 12, 2023

What changes were proposed in this pull request?

  • Exclude unnecessary Cat X licenses where possible. Per the incubator release vote, there were several Category X licenses in the binaries as well as a missing 3rd party license in the LICENSE file. This change skip tests when packaging, excludes several artifacts in the pom to prevent the licenses from being unnecessarily included, generates the THIRD-PARTY.txt file, and merges several variants of the Apache license.

How was this patch tested?

Building project during release process

Please review https://livy.incubator.apache.org/community/ before opening a pull request.

* Exclude unnecessary Cat X licenses where possible.
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #429 (5ca81c7) into master (8b2e29f) will increase coverage by 2.50%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #429      +/-   ##
============================================
+ Coverage     65.48%   67.99%   +2.50%     
- Complexity      950      975      +25     
============================================
  Files           103      103              
  Lines          6062     6062              
  Branches        916      916              
============================================
+ Hits           3970     4122     +152     
+ Misses         1541     1353     -188     
- Partials        551      587      +36     

see 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ksumit ksumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dacort can you please update the PR description to provide more context on these changes? I understood that these changes were required for 0.8 release but do you remember why we had to do these in the first place? This information may be useful for the future.

@dacort
Copy link
Contributor Author

dacort commented Apr 11, 2024

@ksumit Done. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants