Skip to content

Conversation

jlahoda
Copy link
Contributor

@jlahoda jlahoda commented Oct 26, 2018

…ent so that bundles (e.g. gson) can load java.sql.Time on JDK 11; based on jtulach's suggestion.

…ent so that bundles (e.g. gson) can load java.sql.Time on JDK 11; based on jtulach's suggestion.
@jlahoda jlahoda requested a review from geertjanw October 26, 2018 06:01
Copy link

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok


/**
*
* @author Jaroslav Tulach <jtulach@netbeans.org>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the test! Feel free to attribute it to yourself rather than copy&paste the author.

Copy link
Member

@geertjanw geertjanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@jlahoda jlahoda merged commit 25e27ce into apache:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants