Skip to content

Add Dockerfile for CI system and hook into GitHub Actions #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

btashton
Copy link
Contributor

This is a reworking of the Docker container to be used with the GitHub Action CI job for github.com/apache/incubator-nuttx

This should likely replace the PR #13 producing a more modular and smaller docker image. This will also build the docker image on a PR, but will also publish it to this project only on merge.

@btashton
Copy link
Contributor Author

@liuguo09 Sorry it took me so long to get this together after I pointed you at my proof of concept. I was trying to get some extra build caching things done with it via Github Actions but it seems there docker registry does not support it. I still have some basic cache enabled that will only be used if the registry starts supporting it in the future, otherwise it just warns and moves on with the build.

@btashton btashton force-pushed the docker branch 2 times, most recently from a988fd0 to 8d2628e Compare March 22, 2020 05:15

# ESP32 toolchain
COPY --from=nuttx-toolchain-esp32 /tools/xtensa-esp32-elf-gcc/ xtensa-esp32-elf-gcc/
ENV PATH="/tools/xtensa-esp32-elf-gcc/bin:$PATH"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we install esp32 tools here too?

@xiaoxiang781216
Copy link
Contributor

apache/nuttx#437

@liuguo09
Copy link
Contributor

@liuguo09 Sorry it took me so long to get this together after I pointed you at my proof of concept. I was trying to get some extra build caching things done with it via Github Actions but it seems there docker registry does not support it. I still have some basic cache enabled that will only be used if the registry starts supporting it in the future, otherwise it just warns and moves on with the build.

@btashton Thanks for your great work. As to the caching things, we could refine them later once supported by github docker registry. When this PR merged and the new docker image available, we could replace my own liuguo09/ubuntu-nuttx docker to make the CI more official and efficient : )

Signed-off-by: Brennan Ashton <bashton@brennanashton.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 9c02f21 into apache:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants