Skip to content

Conversation

xiaoxiang781216
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 commented Oct 26, 2020

Summary

To fix the issue: apache/nuttx#2094
Need merge apache/nuttx#2128 first.

Impact

The automation build

Testing

@btashton
Copy link
Contributor

btashton commented Oct 26, 2020

Can we consider what I did in this PR instead #71 I find to easier to have the restrictions for an host in a single file rather than mixed with all the targets. It would also make it easier to have modifiers a for a host added later.

@xiaoxiang781216
Copy link
Contributor Author

xiaoxiang781216 commented Oct 26, 2020

Can we consider what I did in this PR instead #71 I find to easier to have the restrictions for an host in a single file rather than mixed with all the targets.

But puting all blacklist in one place give us the whole picture and the difference between host quickly.

It would also make it easier to have modifiers a for a host added later.

I am thinking to change blacklist to regex pattern instead using config as regex, then we don't need change the match anymore and write the complex parttern, e.g.: -sim:nsh,(Linux)|(Darwin).

since macOS don't support them

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@btashton
Copy link
Contributor

Merged OS side, just restarted the build.

@jerpelea jerpelea merged commit 21bed31 into apache:master Oct 28, 2020
@xiaoxiang781216 xiaoxiang781216 deleted the mac branch October 28, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants