Fix the initial idle tasks environment #5753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarashchenko
requested review from
xiaoxiang781216,
pkarashchenko,
masayuki2009 and
Ouss4
- User mode allocator was used for setting up the environment. This works in flat mode and probably in protected mode as well, as there is always a a single user allocator present - This does not work in kernel mode, where each user task has its own heap allocator. Also, when the idle tasks environment is being set, no allocator is ready and the system crashes at once. Fix this by using the group allocators instead: - Idle task is a kernel task, so its group is privileged - Add group_realloc - Use the group_malloc/realloc functions instead of kumm_malloc
pkarashchenko
approved these changes
Mar 16, 2022
xiaoxiang781216
approved these changes
Mar 16, 2022
pussuw
added a commit
to tiiuae/nuttx
that referenced
this pull request
Mar 21, 2022
When the initial proxy task is duplicated into the first user task, the environment exists in kernel memory and this must be copied to user memory. The memory allocated for the new task was allocated with the parent's priority which is incorrect. Use the new task's priority instead. Follow-up for: apache#5753
xiaoxiang781216
pushed a commit
that referenced
this pull request
Mar 22, 2022
When the initial proxy task is duplicated into the first user task, the environment exists in kernel memory and this must be copied to user memory. The memory allocated for the new task was allocated with the parent's priority which is incorrect. Use the new task's priority instead. Follow-up for: #5753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works in flat mode and probably in protected mode as well, as there
is always a a single user allocator present
heap allocator. Also, when the idle tasks environment is being set,
no allocator is ready and the system crashes at once.
Fix this by using the group allocators instead:
Summary
Fixes the initial environment, especially with CONFIG_BUILD_KERNEL
Impact
Testing
Tested with boards/risc-v/mpfs/icicle/configs/knsh/defconfig (CONFIG_BUILD_KERNEL=y) / not released yet