libc/stdio: Support 'e'(O_CLOEXEC) in lib_mode2oflags #6357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
force-pushed
the
fopen
branch
2 times, most recently
from
284ea37
to
cc78e04
Compare
davids5
added
the
breaking change
|
@davids5 this isn't breaking change, both flags still exist. BTW, no code in NuttX handle O_BINARY/O_TEXT flag at all, how it will break your code? |
davids5
removed
the
breaking change
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
follow BSD and Linux convention: https://man.openbsd.org/fopen https://www.man7.org/linux/man-pages/man3/fopen.3.html Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
…XCL) Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
follow BSD and Linux convention: https://man.openbsd.org/fopen https://www.man7.org/linux/man-pages/man3/fopen.3.html Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
POSIX require file system shouldn't enable the \r and \n conversion by default Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
pkarashchenko
approved these changes
Jun 5, 2022
pkarashchenko
approved these changes
Jun 7, 2022
anchao
added a commit
to anchao/nuttx
that referenced
this pull request
Apr 11, 2023
follow the change: apache#6357 Signed-off-by: chao an <anchao@xiaomi.com>
anchao
added a commit
to anchao/nuttx
that referenced
this pull request
Apr 11, 2023
1. align the operation flags define with fcntl.h follow the change: apache#6357 2. enable O_BINARY flag to set the default setting to untranslated mode Since the initial default setting in MSVC is text mode ( _O_TEXT ): https://learn.microsoft.com/en-us/cpp/c-runtime-library/text-and-binary-mode-file-i-o?view=msvc-170 Signed-off-by: chao an <anchao@xiaomi.com>
anchao
added a commit
to anchao/nuttx
that referenced
this pull request
Apr 11, 2023
follow the change: apache#6357 Signed-off-by: chao an <anchao@xiaomi.com>
xiaoxiang781216
pushed a commit
that referenced
this pull request
Apr 18, 2023
follow the change: #6357 Signed-off-by: chao an <anchao@xiaomi.com>
anchao
added a commit
to anchao/nuttx
that referenced
this pull request
Jul 14, 2023
follow the change: apache#6357 Signed-off-by: chao an <anchao@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
and make the binary(no process) mode as the default
Impact
Can add O_CLOEXEC flags in fopen
Testing
Pass CI