Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Only rewrite an image once even if it's requested via ipro many times
concurrently. Print elapsed time properly for subshell tests. Fix typo in SVG reference which was causing spurious timeout warnings in nginx tests, and then flagged by nginx system tests. Remove nginx test flakiness by using fetch_until an image gets small to indicate an ipro-rewrite is done, rather than testing for image_ongoing_rewrites to be zero. The old technique might fail because we might check that stat before the image starts being rewritten. Note: with this change, nginx system tests no longer flake for me, whereas previously about 10% of the time it would flake on "IPRO flow uses cache as expected". That was also suppressed for valgrind runs, which is no longer needed. Even after this change, nginx system tests with valgrind tests still flake with "Fetch timed out" log messages, which I am adding to the suppressions, and with "Embed image configuration in rewritten image URL.", where the recursive-wget result is not optimized. I think that might be a real user-facing bug, and I will report it to the nginx list.
- Loading branch information
Showing with 29 additions and 11 deletions.