reapply: location-header: tweak location header handling

- Fix potentially sending the location header into PSOL twice. - Be more thorough when unsetting the location header Attempts to fix #725 from oschaaf
apache · Dec 31, 2015 · 059dd20b105a1e6b1f0d5b23526e79e026d9a77f · 059dd20
1 parent 56a5d41
commit 059dd20b105a1e6b1f0d5b23526e79e026d9a77f
Unified Split

Showing with 6 additions and 5 deletions.

+6 −5 src/ngx_pagespeed.cc
diff --git a/src/ngx_pagespeed.cc b/src/ngx_pagespeed.cc
@@ -302,6 +302,12 @@ ngx_int_t ps_base_fetch_handler(ngx_http_request_t* r) {
                 STR_CASE_EQ_LITERAL(header->key, "Last-Modified") ||
                 STR_CASE_EQ_LITERAL(header->key, "Expires"))))) {
           header->hash = 0;
+          if (STR_CASE_EQ_LITERAL(header->key, "Location")) {
+            // There's a possible issue with the location header, where setting
+            // the hash to 0 is not enough. See:
+            // https://github.com/nginx/nginx/blob/master/src/http/ngx_http_header_filter_module.c#L314
+            r->headers_out.location = NULL;
+          }
         }
       }
     } else {
@@ -452,11 +458,6 @@ void copy_response_headers_from_ngx(const ngx_http_request_t* r,
 
   headers->set_status_code(r->headers_out.status);
 
-  if (r->headers_out.location != NULL) {
-    headers->Add(HttpAttributes::kLocation,
-                 str_to_string_piece(r->headers_out.location->value));
-  }
-
   // Manually copy over the content type because it's not included in
   // request_->headers_out.headers.
   headers->Add(HttpAttributes::kContentType,